Closed Bug 1170023 Opened 9 years ago Closed 23 days ago

Potential string buffer overflow in DEBUG code

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Type:
defect

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: MatsPalmgren_bugz, Unassigned)

Details

(Whiteboard: [gfx-noted]) 

http://mxr.mozilla.org/mozilla-central/source/gfx/layers/LayerSorter.cpp#178

It looks like the buffer might be too small for that format string.
We should increase the size and change sprintf to snprintf_literal.
Why doesn't this just use the printf instead of the two pass approach?
Assignee: nobody → matt.woodrow
Flags: needinfo?(matt.woodrow)
Whiteboard: [gfx-noted]
I have no explanation, seems like printf would be fine.
Flags: needinfo?(matt.woodrow)

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: matt.woodrow → nobody
Severity: minor → S4
Status: NEW → RESOLVED
Closed: 23 days ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.