Closed Bug 1170035 Opened 5 years ago Closed 5 years ago

Always show protocol version in network monitor

Categories

(DevTools :: Netmonitor, enhancement)

enhancement
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: veeti.paananen, Assigned: veeti.paananen)

Details

Attachments

(1 file, 1 obsolete file)

Now that HTTP2 is becoming commonplace, I think that it would be helpful to always show the used protocol for network requests to avoid confusion. It's not particularly intuitive that some requests show the used version yet some don't.
Attached patch Patch (obsolete) — Splinter Review
Attachment #8613320 - Flags: review?(vporof)
Comment on attachment 8613320 [details] [diff] [review]
Patch

Review of attachment 8613320 [details] [diff] [review]:
-----------------------------------------------------------------

Should DEFAULT_HTTP_VERSION be removed now?
Does this break any tests?
Attachment #8613320 - Flags: review?(vporof) → feedback+
Removed unused constant. All tests pass for me.
Attachment #8613320 - Attachment is obsolete: true
Attachment #8613962 - Flags: review?(vporof)
Attachment #8613962 - Flags: review?(vporof) → review+
Assignee: nobody → veeti.paananen
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d3f0281f7357
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.