1170038 - Invalid string formatting in refdata.py _add_platform() and _add_name_and_symbol()

Status: RESOLVED INVALID

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

In _add_platform():
https://github.com/mozilla/treeherder/blob/acbc0b6d362880e2a3dbae7ae2ffda0d1ce33bd4/treeherder/model/derived/refdata.py#L438
            # WHERE clause for the retrieval SELECT
            where_filters.append(
                "(`os_name` = %s  AND `platform` = %s  AND `architecture` = %s)".format(
                    os_name, platform, arch
                )
            )

In _add_name_and_symbol():
https://github.com/mozilla/treeherder/blob/acbc0b6d362880e2a3dbae7ae2ffda0d1ce33bd4/treeherder/model/derived/refdata.py#L499
            where_filters.append(
                "(`name` = %s  AND `symbol` = %s)".format(name, symbol)
            )

Using "%s" with .format() doesn't work. eg:

>>> print "(`name` = %s  AND `symbol` = %s)".format("Foo", "F")
(`name` = %s  AND `symbol` = %s)

So not sure how this is currently working?

Changing the "%s" to "{}" causes tests to fail... unless we're testing broken behaviour?

Comment 1

[William Lachance (:wlach)]

This code is no longer operative.