1170051 - second screen share in a room doesn't layout correctly (race)

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Firefox_Hello.png

While trying to figure out how I regressed this, I tried testing the production install, and it turns out we're already broken this way in production.

This seems to be a race (i.e. it doesn't reproduce 100% of the time, but frequently).

It looks ugly enough that we may want to try to fix it in the release before 38.0.5 (ie Monday).  :-)

I haven't yet had a chance to investigate more deeply, but it kinda looks like adding:

      if (nextState.receivingScreenShare) {
        // Force the video sizes to update.
        this.updateVideoContainer();
      }

into StandaloneRoomView.componentWillUpdate will at least paper over it, and may even be the right fix.

Comment 1

[Mike de Boer [:mikedeboer]]

(In reply to Dan Mosedale (:dmose) - needinfo? me for response from comment #0)
>       if (nextState.receivingScreenShare) {
>         // Force the video sizes to update.
>         this.updateVideoContainer();
>       }

I'd take this.

Comment 2

[Mark Banner (:standard8)]

Attachment: Fix issues with screen shares not correctly laying out on Loop standalone UI - remove the video dimensions from the cache when the share is stopped.

My local testing shows this should fix the issue. I think this is a better fix, as I believe the various caches are causing the previous dimensions to be saved, so turning screensharing off and then on again detects the cached values are the same, and doesn't fully recalculate the location.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7af23a7daff5

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7af23a7daff5