Open Bug 1170078 Opened 10 years ago Updated 3 years ago

errors during reparsing of CSS property values with variable references should include their sheet URL

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

Tracking Status
firefox41 --- affected

People

(Reporter: heycam, Unassigned)

References

Details

In bug 952338 and bug 1168156 we removed the mSheet member of nsCSSValueTokenStreamValue objects. We should work out how to add it back safely so that errors during re-parsing of CSS properties with variable references get reported with a location properly.
One possible solution is mentioned in bug 952338 comment 5.
Do you need the sheet? Or just its URI?
Oh, I was wrong about it being for the error location -- we already pass through a URI to the ErrorReporter. The sheet is used solely for finding the window ID for where to report the error. So maybe we could pass the window ID into nsCSSParser::ParsePropertyWithVariableReferences instead of the sheet?
That would make sense, yes.
See Also: → 1258967
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.