Closed
Bug 1170079
Opened 9 years ago
Closed 9 years ago
Sync incorrectly reports a prolonged error.
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: markh, Assigned: markh)
References
Details
(Keywords: regression)
Attachments
(1 file)
5.70 KB,
patch
|
adw
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Somewhat embarrassingly, browser-syncui will think every Sync error is a "prolonged" error if that profile has ever previously synced with the now disabled "readinglist", as the last successful RL sync was well over 2 weeks ago. Profiles that never configured RL are not affected. isProlongedReadingListError() should return false if readinglist.scheduler.enabled is false. (I'm not putting up a patch yet, as I can still see this errorbar remain even when Sync subsequently completes successfully, and I'm trying to work out why that's the case)
Comment 1•9 years ago
|
||
Mark: please double-check my tracking flags!
status-firefox38.0.5:
--- → unaffected
status-firefox39:
--- → ?
status-firefox40:
--- → affected
status-firefox41:
--- → affected
tracking-firefox40:
--- → ?
Assignee | ||
Comment 2•9 years ago
|
||
Regression from bug 1131413 which landed on 38
Blocks: 1131413
status-firefox38:
--- → affected
Assignee | ||
Comment 3•9 years ago
|
||
Drew, this is a regression from when we changes browser-syncui to support the reading list. If a profile has ever done a reading-list sync in the past but now has the reading-list disabled we act as though there is a "prolonged" sync error. This patch ignores the last-sync date if the reading-list scheduler is disabled.
Updated•9 years ago
|
Attachment #8614528 -
Flags: review?(adw) → review+
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/927f0de4430c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8614528 [details] [diff] [review] 0002-Bug-1170079-don-t-treat-an-old-readinglist-last-sync.patch Approval Request Comment [Feature/regressing bug #]: reading list regression [User impact if declined]: Sync will show an infobar telling them Sync hasn't completed for 2 weeks, which is incorrect. [Describe test coverage new/current, TreeHerder]: New test [Risks and why]: Very low, limited to the Sync UI [String/UUID change made/needed]: None
Attachment #8614528 -
Flags: approval-mozilla-beta?
Attachment #8614528 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
Comment on attachment 8614528 [details] [diff] [review] 0002-Bug-1170079-don-t-treat-an-old-readinglist-last-sync.patch Approved for uplift to aurora and beta.
Attachment #8614528 -
Flags: approval-mozilla-beta?
Attachment #8614528 -
Flags: approval-mozilla-beta+
Attachment #8614528 -
Flags: approval-mozilla-aurora?
Attachment #8614528 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
Keywords: regression
Updated•9 years ago
|
Comment 10•9 years ago
|
||
Since this was fixed and approved for uplift, I went ahead and tracked for 40, to make sure it is resolved there.
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•