1170079 - Sync incorrectly reports a prolonged error.

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Somewhat embarrassingly, browser-syncui will think every Sync error is a "prolonged" error if that profile has ever previously synced with the now disabled "readinglist", as the last successful RL sync was well over 2 weeks ago.

Profiles that never configured RL are not affected.

isProlongedReadingListError() should return false if readinglist.scheduler.enabled is false.

(I'm not putting up a patch yet, as I can still see this errorbar remain even when Sync subsequently completes successfully, and I'm trying to work out why that's the case)

Comment 1

[Richard Newman [:rnewman]]

Mark: please double-check my tracking flags!

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Regression from bug 1131413 which landed on 38

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0002-Bug-1170079-don-t-treat-an-old-readinglist-last-sync.patch

Drew, this is a regression from when we changes browser-syncui to support the reading list.  If a profile has ever done a reading-list sync in the past but now has the reading-list disabled we act as though there is a "prolonged" sync error. This patch ignores the last-sync date if the reading-list scheduler is disabled.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/927f0de4430c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/927f0de4430c

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8614528 [details] [diff] [review]
0002-Bug-1170079-don-t-treat-an-old-readinglist-last-sync.patch

Approval Request Comment
[Feature/regressing bug #]: reading list regression
[User impact if declined]: Sync will show an infobar telling them Sync hasn't completed for 2 weeks, which is incorrect.
[Describe test coverage new/current, TreeHerder]: New test
[Risks and why]: Very low, limited to the Sync UI
[String/UUID change made/needed]: None

Comment 7

[Liz Henry (:lizzard)]

Comment on attachment 8614528 [details] [diff] [review]
0002-Bug-1170079-don-t-treat-an-old-readinglist-last-sync.patch

Approved for uplift to aurora and beta.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2ad79acb7c81

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9dd33c2b4304

Comment 10

[jen strickland :jenstrickland]

Since this was fixed and approved for uplift, I went ahead and tracked for 40, to make sure it is resolved there.