Closed Bug 1170086 Opened 8 years ago Closed 7 years ago

[Bluetooth2] DispatchReplyError() should reply |BluetoothStatus| instead of |BluetoothValue(nsString)| in LE scan result handle.

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
2.2 S14 (12june)
Tracking Status
firefox41 --- fixed

People

(Reporter: jaliu, Assigned: jaliu)

Details

Attachments

(1 file, 2 obsolete files)

DispatchReplyError() shouldn't take |BluetoothValue| as its parameter.
It should only replay |nsAString| or |BluetoothStatus|.
Assignee: nobody → jaliu
Thank Bruce Sun for helping me found this bug.
Comment on attachment 8613405 [details] [diff] [review]
Fix the parameter type of DispatchReplyError() in startLeScan result handler. (v1)

Review of attachment 8613405 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluedroid/BluetoothGattManager.cpp
@@ +521,5 @@
>          new BluetoothVoidReplyRunnable(nullptr);
>        gattManager->UnregisterClient(mClient->mClientIf, result);
>      }
>  
> +    DispatchReplyError(mClient->mStartLeScanRunnable, mClient->mAppUuid);

Hi Jamin,

This error string isn't descriptive.
I would suggest to reject with a error status here.

Thanks,
Jocelyn
Attachment #8613405 - Flags: review?(joliu)
Summary: [Bluetooth2] DispatchReplyError() should reply |nsString| instead of |BluetoothValue(nsString)| in LE scan result handle. → [Bluetooth2] DispatchReplyError() should reply |BluetoothStatus| instead of |BluetoothValue(nsString)| in LE scan result handle.
- revise previous patch based on #comment 3
Attachment #8613405 - Attachment is obsolete: true
Attachment #8613474 - Flags: review?(joliu)
Comment on attachment 8613474 [details] [diff] [review]
Fix the parameter type of DispatchReplyError() in startLeScan result handler. (v2)

Review of attachment 8613474 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks!
Attachment #8613474 - Flags: review?(joliu) → review+
- add reviewer's name to commit message
- convert to hg format.

Thank Jocelyn for reviewing the patch.
Attachment #8613474 - Attachment is obsolete: true
Skip the "Pushing to Try" procedure since Bluetooth API v2 hasn't be covered by tinderbox.
https://hg.mozilla.org/mozilla-central/rev/69bc92321873
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S14 (12june)
You need to log in before you can comment on or make changes to this bug.