1170086 - [Bluetooth2] DispatchReplyError() should reply |BluetoothStatus| instead of |BluetoothValue(nsString)| in LE scan result handle.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Jamin Liu [:jaliu][:Jamin]]

DispatchReplyError() shouldn't take |BluetoothValue| as its parameter.
It should only replay |nsAString| or |BluetoothStatus|.

Comment 1

[Jamin Liu [:jaliu][:Jamin]]

Attachment: Fix the parameter type of DispatchReplyError() in startLeScan result handler. (v1)

Comment 2

[Jamin Liu [:jaliu][:Jamin]]

Thank Bruce Sun for helping me found this bug.

Comment 3

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8613405 [details] [diff] [review]
Fix the parameter type of DispatchReplyError() in startLeScan result handler. (v1)

Review of attachment 8613405 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluedroid/BluetoothGattManager.cpp
@@ +521,5 @@
>          new BluetoothVoidReplyRunnable(nullptr);
>        gattManager->UnregisterClient(mClient->mClientIf, result);
>      }
>  
> +    DispatchReplyError(mClient->mStartLeScanRunnable, mClient->mAppUuid);

Hi Jamin,

This error string isn't descriptive.
I would suggest to reject with a error status here.

Thanks,
Jocelyn

Comment 4

[Jamin Liu [:jaliu][:Jamin]]

Attachment: Fix the parameter type of DispatchReplyError() in startLeScan result handler. (v2)

- revise previous patch based on #comment 3

Comment 5

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8613474 [details] [diff] [review]
Fix the parameter type of DispatchReplyError() in startLeScan result handler. (v2)

Review of attachment 8613474 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks!

Comment 6

[Jamin Liu [:jaliu][:Jamin]]

Attachment: Fix the parameter type of DispatchReplyError() in startLeScan result handler. (v2.1), r=joliu

- add reviewer's name to commit message
- convert to hg format.

Thank Jocelyn for reviewing the patch.

Comment 7

[Jamin Liu [:jaliu][:Jamin]]

Skip the "Pushing to Try" procedure since Bluetooth API v2 hasn't be covered by tinderbox.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/69bc92321873

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/69bc92321873