1170124 - Remove unnecessary type monitoring in jit::InvokeFunction

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

InvokeFunction is the slow path for calls from Ion code. It calls cx->currentScript and TypeScript::Monitor, but this is unnecessary as all calls from Ion code have type barriers in JIT code. (This used to be different before the TI overhaul.)

The attached patch also changes the Value* outparam to MutableHandleValue.

This improves the micro-benchmark in bug 1170107 from 1500 ms to 1060 ms.

Comment 1

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/54d579c1a164

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/baa684fab4f5 for turning XP debug Jittests permafail:

https://treeherder.mozilla.org/logviewer.html#?job_id=10321799&repo=mozilla-inbound

Comment 3

[Jan de Mooij [:jandem]]

(In reply to Wes Kocher (:KWierso) from comment #2)
> Backed out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/baa684fab4f5 for
> turning XP debug Jittests permafail:

Hm. This is the weirdest thing ever. WinXP Debug only, looks like jit_test.py hangs, I don't really understand why; the output just stops near the end. Will try to bisect this on Try

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b2e868ee411

Comment 5

[Jan de Mooij [:jandem]]

Relanded this with --no-ion annotation added to |jit-test/tests/gc/bug-1165966.js|.

jonco said he's seen the same issue with these OOM tests on WinXP; the patch is pretty simple but probably slightly changes some allocation or timing thing :(

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cc85f8e7438

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7b2e868ee411