1170125 - [NGA][Contacts] Extract everything related to "mozContacts" to a separate .js file

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Borja Salguero [:borjasalguero]]

In order to move our Contacts App to the new architecture, we are going to move all requests to the API to a well-defined .js file.

This will help us to move from the current model to the one based on Threads.js in a transparent way.

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Patch

Hi Francisco! I've exposed a new interface in order to have the whole functionality of mozContacts in one file, having it ready for moving the app easily to Threads.js.

I'll add all tests once the we confirm that the interface is the right one. Could you take a look? Thanks! :)

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8613606 [details] [review]
Patch

Could we move the interface to use promises? The changes needed in contacts will be minimun and we will be even closer to moving tho threads.js

Comment 3

[Borja Salguero [:borjasalguero]]

After talking with Francisco, we both agreed  that for not merging a huge patch, we are going to keep the 'callback' approach by now (with all tests working), and we will revisit this later on.

Comment 4

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8615211 [details] [review]
Pull Request

Tested on the phone and working perfectly.

Left some comments on gh, but one resolved we are ready to merge.

Great work here!

Comment 6

[Borja Salguero [:borjasalguero]]

Thanks Francisco! All tests passed and all comments addressed. Merging!

Comment 7

[Kevin Grandon :kgrandon]

Backed out for causing Gip20 failures: https://github.com/mozilla-b2g/gaia/commit/1d62b32408567f9f7cf1c71c1e5a0c6593be757b

https://treeherder.mozilla.org/logviewer.html#?job_id=1302935&repo=gaia

Comment 8

[Borja Salguero [:borjasalguero]]

Hi Kevin! After checking all jobs in "treeharder" this intermittent failure appears in some of them. I've reopened https://bugzilla.mozilla.org/show_bug.cgi?id=1079233 due to seems to be a well-known issue.

Comment 9

[Kevin Grandon :kgrandon]

True, but it was fairly certain that this caused a perma-red. Please verify that there's no red tests in a pull request, and if not, feel free to re-land.

Comment 10

[Borja Salguero [:borjasalguero]]

All tests passed, so merging!