Open
Bug 1170145
Opened 9 years ago
Updated 1 year ago
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2013'
Categories
(Firefox Build System :: Mach Core, enhancement)
Firefox Build System
Mach Core
Tracking
(Not tracked)
NEW
People
(Reporter: kats, Unassigned)
References
Details
Attachments
(1 file)
4.11 KB,
text/plain
|
Details |
Synced to gecko-dev git cset cfa2965ba (hg 39c85ec2d6) with attachment 8613181 [details] [diff] [review] applied on top. OS X. Did a |mach build| followed by |mach mochitest --tag apz-chrome --e10s| and got the attached output.
Reporter | ||
Comment 1•9 years ago
|
||
I printed the "test" variable in testing/mozbase/manifestparser/manifestparser/filters.py line 31, and it spit out this just before crashing: {u'head': u'head.js', u'skip-if': u'e10s # Feature not implemented yet \u2013 bug 1140310', u'name': u'browser_aboutperformance.js', u'support-files': u'\nbrowser_compartments.html\nbrowser_compartments_frame.html\nbrowser_compartments_script.js', u'here': u'/Users/kats/zspace/mozilla-git/obj-host/_tests/testing/mochitest/browser/toolkit/components/aboutperformance/tests/browser', u'manifest': u'/Users/kats/zspace/mozilla-git/toolkit/components/aboutperformance/tests/browser/browser.ini', u'subsuite': u'', u'file_relpath': u'toolkit/components/aboutperformance/tests/browser/browser_aboutperformance.js', 'expected': 'pass', u'path': u'/Users/kats/zspace/mozilla-git/obj-host/_tests/testing/mochitest/browser/toolkit/components/aboutperformance/tests/browser/browser_aboutperformance.js', u'flavor': u'browser-chrome', u'dir_relpath': u'toolkit/components/aboutperformance/tests/browser', u'relpath': u'toolkit/components/aboutperformance/tests/browser/browser_aboutperformance.js'}
Reporter | ||
Comment 2•9 years ago
|
||
It's the dash character at http://mxr.mozilla.org/mozilla-central/source/toolkit/components/aboutperformance/tests/browser/browser.ini?rev=8b2ad894ed27#11 that's causing the failure.
The objective of this bug is to change one character in http://mxr.mozilla.org/mozilla-central/source/toolkit/components/aboutperformance/tests/browser/browser.ini?rev=8b2ad894ed27#11 Replace "–" (long dash) with "-" (short dash).
Mentor: dteller
Whiteboard: [good first bug]
Comment 4•9 years ago
|
||
I think we should fix the root problem instead of papering over by changing a dash. I'm also not sure that a one liner patch whose entire purpose can be described in a 4 words sentence is really worth a mentored bug, both for mentor time, and for new contributor time (relatedly, I thought "good first bug" was deprecated for the mentor field).
Comment 5•9 years ago
|
||
since the bug (https://bugzilla.mozilla.org/show_bug.cgi?id=674779) is closed The line has been deleted from the file So this bug no longer exists now.
Comment 6•9 years ago
|
||
I fail to see how bug 674779 is related to this one.
Comment 7•9 years ago
|
||
If you see the line https://mxr.mozilla.org/mozilla-central/source/toolkit/components/aboutperformance/tests/browser/browser.ini?rev=8b2ad894ed27#11 and the latest version https://mxr.mozilla.org/mozilla-central/source/toolkit/components/aboutperformance/tests/browser/browser.ini since the bug 674779 is fixed the line has been deleted from the file
Comment 8•9 years ago
|
||
I am sorry i meant the line bug skip-if = e10s # Feature not implemented yet – bug 1140310 has been removed
Comment 9•9 years ago
|
||
What I meant is that the current version of the file doesn't have the dash at all to edit it
Comment 10•9 years ago
|
||
The current version of the file doesn't contain the line which is causing the bug which in other words means that this bug no longer exists, so you can assign it to me and I close it or close it by yourself :)
Flags: needinfo?(dteller)
As glandium suggested in comment 4, let's keep this bug open to fix the underlying issue.
Mentor: dteller
Flags: needinfo?(dteller)
Comment 12•9 years ago
|
||
Then you better remove the [good first bug] in whiteboard if you are intending to fix the root cause as it's not a easy one and many newbies like me may want to fix it :) like me
Reporter | ||
Updated•9 years ago
|
Whiteboard: [good first bug]
Updated•6 years ago
|
Product: Core → Firefox Build System
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•1 year ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•