If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Migrate integration tests between SMS and Contacts to Gij

RESOLVED FIXED

Status

Firefox OS
Gaia::SMS
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jlorenzo, Assigned: jlorenzo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
arcturus
: review+
azasypkin
: review+
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
Original test: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_add_contact.py
(Assignee)

Comment 1

2 years ago
Actually, these 3 tests need to test the integration between Contacts and Dialer. Mocking the contactsDB won't be enough.
* test_sms_add_contact.py
* test_add_to_an_existing_contact_from_messages.py
* test_add_to_new_contact_from_messages.py
No longer depends on: 1168324
Summary: Migrate test_sms_add_contact.py to Gij → Migrate integration tests between SMS and Contacts to Gij
(Assignee)

Updated

2 years ago
Depends on: 1168118
(Assignee)

Comment 2

2 years ago
Created attachment 8617251 [details] [review]
Gaia PR
(Assignee)

Updated

2 years ago
Assignee: nobody → jlorenzo
(Assignee)

Comment 3

2 years ago
Comment on attachment 8617251 [details] [review]
Gaia PR

This needs bug 1168118 to be landed first. I cherry-picked the commits from that bug. The relevant changes are in the last commit. Like in bug 1156753, I put the cross app test in tests/integration/sms.
Attachment #8617251 - Flags: review?(francisco)
Attachment #8617251 - Flags: review?(azasypkin)
Comment on attachment 8617251 [details] [review]
Gaia PR

Changes on contacts looking good to me.
Attachment #8617251 - Flags: review?(francisco) → review+
Comment on attachment 8617251 [details] [review]
Gaia PR

PR for bug 1168118 is r+'ed, could you please rebase this PR on master once bug 1168118 lands and ask review again?

From my bitter experience it's better rely on the latest source only for the integration test PRs :)

Thanks!
Attachment #8617251 - Flags: review?(azasypkin)
(Assignee)

Comment 6

2 years ago
Comment on attachment 8617251 [details] [review]
Gaia PR

Rebased. Gij29 has shown blue, but no tests were run.
Attachment #8617251 - Flags: review?(azasypkin)
Comment on attachment 8617251 [details] [review]
Gaia PR

Looks good, just several nits at GitHub.

Thanks!
Attachment #8617251 - Flags: review?(azasypkin) → review+
(Assignee)

Comment 8

2 years ago
Encountered an issue[1] that could be solved by bug 1140344

[1] https://github.com/mozilla-b2g/gaia/pull/30500/files#r32426637
Blocks: 1140344
(Assignee)

Updated

2 years ago
Blocks: 1175080
(Assignee)

Comment 9

2 years ago
The create new contact test turns out to be intermittent (approximately 1 out of 10 times[1]) because of Marionette (bug 1175080). I discussed with :Tomcat on IRC, he's okay with me to land it and flag it to bug 1175080.

Side note: The JSHint job is currently failing because of a commit that happened earlier in the tree.

Merged in master at: https://github.com/mozilla-b2g/gaia/commit/ae442387444d7e647ec183bfcf13d846d108bbb0

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=1fe8bc6266f2873798fc803cbea33b2dbc44f9b7
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Blocks: 1175110
You need to log in before you can comment on or make changes to this bug.