1170151 - Migrate integration tests between SMS and Contacts to Gij

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Original test: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_add_contact.py

Comment 1

[Johan Lorenzo [:jlorenzo]]

Actually, these 3 tests need to test the integration between Contacts and Dialer. Mocking the contactsDB won't be enough.
* test_sms_add_contact.py
* test_add_to_an_existing_contact_from_messages.py
* test_add_to_new_contact_from_messages.py

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8617251 [details] [review]
Gaia PR

This needs bug 1168118 to be landed first. I cherry-picked the commits from that bug. The relevant changes are in the last commit. Like in bug 1156753, I put the cross app test in tests/integration/sms.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8617251 [details] [review]
Gaia PR

Changes on contacts looking good to me.

Comment 5

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8617251 [details] [review]
Gaia PR

PR for bug 1168118 is r+'ed, could you please rebase this PR on master once bug 1168118 lands and ask review again?

From my bitter experience it's better rely on the latest source only for the integration test PRs :)

Thanks!

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8617251 [details] [review]
Gaia PR

Rebased. Gij29 has shown blue, but no tests were run.

Comment 7

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8617251 [details] [review]
Gaia PR

Looks good, just several nits at GitHub.

Thanks!

Comment 8

[Johan Lorenzo [:jlorenzo]]

Encountered an issue[1] that could be solved by bug 1140344

[1] https://github.com/mozilla-b2g/gaia/pull/30500/files#r32426637

Comment 9

[Johan Lorenzo [:jlorenzo]]

The create new contact test turns out to be intermittent (approximately 1 out of 10 times[1]) because of Marionette (bug 1175080). I discussed with :Tomcat on IRC, he's okay with me to land it and flag it to bug 1175080.

Side note: The JSHint job is currently failing because of a commit that happened earlier in the tree.

Merged in master at: https://github.com/mozilla-b2g/gaia/commit/ae442387444d7e647ec183bfcf13d846d108bbb0

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=1fe8bc6266f2873798fc803cbea33b2dbc44f9b7