1170154 - unverified Addon warning should be yellow (not red) even if pref to require signing is on

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Markus Jaritz [:designakt] (UX)]

Attachment: Screen Shot 2015-06-01 at 16.07.42.png

As the state of the addon is not changing when changing the pref, it should remain a yellow warning and not become a red error when xpinstall.signatures.required = true .

For unverified addons we can not know if they are bad or not, so we can only warn, but not state that they are harmful. Thus only color it yellow and not red.

Comment 1

[Dave Townsend [:mossop]]

(In reply to Markus Jaritz [:maritz] (UX) from comment #0)
> Created attachment 8613512 [details]
> Screen Shot 2015-06-01 at 16.07.42.png
> 
> As the state of the addon is not changing when changing the pref, it should
> remain a yellow warning and not become a red error when
> xpinstall.signatures.required = true .
> 
> For unverified addons we can not know if they are bad or not, so we can only
> warn, but not state that they are harmful. Thus only color it yellow and not
> red.

The policy we've used in the past is to show a warning when there is something that the user should be aware of but can override (add-ons that are incompatible when compatibility checking is disabled, add-ons that are soft-blocked) and an error when an add-on is forcibly disabled by the application. Being disabled because signing is required matches the latter. Do you still want to change this?

Comment 2

[Markus Jaritz [:designakt] (UX)]

If that is how all others are judged then let's leave it red. It might paint a darker picture of unverified add-ons than we can really tell, but once all good add-ons are signed, only bad will be left.