Remove various dead functions

RESOLVED FIXED in Firefox 41

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

Posted patch PatchSplinter Review
I was skimming jcranmer's coverage data for js/src and noticed a bunch of dead functions.

 28 files changed, 0 insertions(+), 400 deletions(-)
Attachment #8613546 - Flags: review?(jorendorff)
Comment on attachment 8613546 [details] [diff] [review]
Patch

Review of attachment 8613546 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsfriendapi.cpp
@@ -1034,5 @@
>  
> -JS_FRIEND_API(int64_t)
> -GetMaxGCPauseSinceClear(JSRuntime* rt)
> -{
> -    return rt->gc.stats.getMaxGCPauseSinceClear();

Er, I think this is still used by js/src/builtin/Profilers.cpp. (Same with the next function.)
(In reply to Steve Fink [:sfink, :s:] from comment #1)
> Er, I think this is still used by js/src/builtin/Profilers.cpp. (Same with
> the next function.)

Profilers.cpp defines different functions with the same name (it confused me too...)
Comment on attachment 8613546 [details] [diff] [review]
Patch

Review of attachment 8613546 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsarray.cpp
@@ -3594,5 @@
> -    arr->setDenseInitializedLength(length);
> -    arr->initDenseElements(0, vp, length);
> -
> -    return arr;
> -}

I will need to resurrect this code later -- or something like it -- but definitely kill it for now. I'm only commenting here as a memo to myself.
Attachment #8613546 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/8fe7179bfc6c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.