1170182 - Remove various dead functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

I was skimming jcranmer's coverage data for js/src and noticed a bunch of dead functions.

 28 files changed, 0 insertions(+), 400 deletions(-)

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8613546 [details] [diff] [review]
Patch

Review of attachment 8613546 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsfriendapi.cpp
@@ -1034,5 @@
>  
> -JS_FRIEND_API(int64_t)
> -GetMaxGCPauseSinceClear(JSRuntime* rt)
> -{
> -    return rt->gc.stats.getMaxGCPauseSinceClear();

Er, I think this is still used by js/src/builtin/Profilers.cpp. (Same with the next function.)

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Steve Fink [:sfink, :s:] from comment #1)
> Er, I think this is still used by js/src/builtin/Profilers.cpp. (Same with
> the next function.)

Profilers.cpp defines different functions with the same name (it confused me too...)

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 8613546 [details] [diff] [review]
Patch

Review of attachment 8613546 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsarray.cpp
@@ -3594,5 @@
> -    arr->setDenseInitializedLength(length);
> -    arr->initDenseElements(0, vp, length);
> -
> -    return arr;
> -}

I will need to resurrect this code later -- or something like it -- but definitely kill it for now. I'm only commenting here as a memo to myself.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8fe7179bfc6c

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8fe7179bfc6c