1170220 - [Secure Element] Unify SE naming in SE/NFC stacks

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: NFC, defect)

Description

[Krzysztof Mioduszewski[:tauzen]]

Currently the origin in HCI EVT_TRANSACTION system message ('nfc-hci-event-transaction') is set to 'SIM1'. Secure Element stack implementation uses 'uicc' as SE type and exposes this value via SE WebAPI. This is confusing for the developers and should be unified.

Comment 1

[Krzysztof Mioduszewski[:tauzen]]

Hi Yoshi, could I get your opinion on this? Since HCI EVT_TRANSACTION origin is set to 'SIM1', ACE will always prevent dispatching it because it expects it to be set to 'uicc' [0][1]. I can add some conversion from 'SIM1' to 'uicc' in the hci system message configurator for the access control check but it would be better to agree on the common type/name to use.

The global platform proposition suggests to use 'uicc'.

[0] - https://github.com/mozilla/gecko-dev/blob/95309090d2f17585aefc12bebf75792e3f152f71/dom/secureelement/gonk/ACEService.js#L115
[1] - https://github.com/mozilla/gecko-dev/blob/95309090d2f17585aefc12bebf75792e3f152f71/dom/secureelement/gonk/ACEService.js#L134-L139

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Please discuss with Gerner and Sidd :).

I am fine either way buy I've asked Garner a couple times the naming needs to be consistent.

I think I also mentioned this before on bugzilla somewhere to Gerner/Sidd but I forgot where it's now. :P

Comment 3

[Garner Lee]

Yeah. Nfcd (Or RIL) is currently sending SIM1, while the upper SE stack is now expecting UICC.

system/nfcd repo:
class TransactionEvent {
public:
  enum OriginType {
    SIM, ESE, ASSD
  };

Comment 4

[Garner Lee]

Attachment: Unify SE naming in SE/NFC stacks patch.

This preliminary patch works between HCI Event Transaction, NFC, and SE. All uppercase, UICC, including slots. "UICC1" being optional means "UICC" to me. I'm not sure if UICC*0* is allowed, or makes sense though.