1170240 - Hamburger menu's green arrow update notification no longer shows up after Nightly update is force-downloaded

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Chris Peterson [:cpeterson]]

I had yesterday's Nightly installed. I opened the "About Nightly" window to force-download the update like I do every morning. Before I clicked the "Restart Nightly to install update" button, the green arrow used to show up immediately in the hamburger menu, but it no longer appears after bug 1102409 was fixed.

Comment 1

[Robert Strong (they/them - no direct email)]

Over irc I was told that this is due to a devtools change.

Comment 2

[:Gijs (he/him)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #1)
> Over irc I was told that this is due to a devtools change.

Yes, see the blocking bug.

Comment 3

[Robert Strong (they/them - no direct email)]

Just noticed the 'hamburger' code mis-uses the update-staged notification. That notification is only sent when staging can be performed and when staging is turned on. I'm more than willing to review this code but no one has flagged me on any of this.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #3)
> Just noticed the 'hamburger' code mis-uses the update-staged notification.
> That notification is only sent when staging can be performed and when
> staging is turned on. I'm more than willing to review this code but no one
> has flagged me on any of this.

Sorry, I somehow thought you had at least seen the patch from bug 1080406. Can you clarify which cases this code doesn't handle well? I'll post a quick patch that displays the badge immediately on Nightly, but I'm happy to fix any other bug in this code.

Comment 5

[Robert Strong (they/them - no direct email)]

(In reply to Panos Astithas [:past] from comment #4)
> (In reply to Robert Strong [:rstrong] (use needinfo to contact me) from
> comment #3)
> > Just noticed the 'hamburger' code mis-uses the update-staged notification.
> > That notification is only sent when staging can be performed and when
> > staging is turned on. I'm more than willing to review this code but no one
> > has flagged me on any of this.
> 
> Sorry, I somehow thought you had at least seen the patch from bug 1080406.
> Can you clarify which cases this code doesn't handle well? I'll post a quick
> patch that displays the badge immediately on Nightly, but I'm happy to fix
> any other bug in this code.
It doesn't appear to handle the case where staging is not possible or staging is disabled via pref. Try setting app.update.staging.enabled to false to disable it and you will get the same result as when staging is not possible.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Only delay the hamburger button update badge in developer edition

This is the tweak to only delay the badge on dev edition. I haven't looked at the staging issue yet.

Comment 7

[:Gijs (he/him)]

Comment on attachment 8614728 [details] [diff] [review]
Only delay the hamburger button update badge in developer edition

Review of attachment 8614728 [details] [diff] [review]:
-----------------------------------------------------------------

You should probably get rstrong to review the actual code, if not here then in another bug.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to :Gijs Kruitbosch from comment #7)
> You should probably get rstrong to review the actual code, if not here then
> in another bug.

Absolutely, the next patch that will deal with staging updates is his.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4b69a62d1905

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4b69a62d1905

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

Filed bug 1171852 for the issue pointed out by Robert.

Comment 12

[6lobe]

I am still affected by this bug. I dont know if its a new regression, but when I manually download the update by opening the About Nightly window, the green notification does not show up. I am on Linux.

Comment 13

[:Gijs (he/him)]

(In reply to 6lobe from comment #12)
> I am still affected by this bug. I dont know if its a new regression, but
> when I manually download the update by opening the About Nightly window, the
> green notification does not show up. I am on Linux.

Please file a new bug with more details.