Switch Thunderbird builds to use Socorro symbol upload API instead of SSH upload

RESOLVED FIXED in Thunderbird 43.0

Status

Thunderbird
Build Config
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: ted, Assigned: Magnus Melin)

Tracking

unspecified
Thunderbird 43.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
See bug 1085557 where we did this for Firefox.

You need to:
1) Log in to crash-stats.mozilla.com
2) File a bug to get symbol upload access for your account
3) Generate a token from crash-stats with symbol upload access: https://crash-stats.mozilla.com/api/tokens/
4) Put that token in a file on the build machines
5) Add to your mozconfig:
```
export SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE=/path/to/token_file
``` like https://dxr.mozilla.org/mozilla-central/source/build/unix/mozconfig.linux#45
(Assignee)

Updated

3 years ago
Assignee: nobody → mkmelin+mozilla
Magnus: Do you have a LDAP account? This sounds to me as if you would need an LDAP account to start - but maybe Ted would know. This doesn't seem to fall clearly within https://www.mozilla.org/en-US/about/governance/policies/commit/access-policy/.
Flags: needinfo?(ted)
Flags: needinfo?(mkmelin+mozilla)
(Assignee)

Comment 2

3 years ago
Yes, ah, my LDAP account is mkmelin@iki.fi (since there's some trouble with + in LDAP account names...)
Flags: needinfo?(mkmelin+mozilla)
(Reporter)

Comment 3

3 years ago
No, it's just straight Persona auth, no LDAP needed.
Flags: needinfo?(ted)
(Reporter)

Updated

3 years ago
Depends on: 1170280
(Assignee)

Comment 4

3 years ago
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #0)
> 4) Put that token in a file on the build machines

How do I do this?
(Reporter)

Comment 5

3 years ago
On https://crash-stats.mozilla.com/api/tokens/, after you've generated a token that has "Upload Symbols Files" permissions, click on "Show the whole token", copy the entire string, paste it into a file, and copy that file to a known location on the build machines. Put the path to that file as SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE as specified in comment 0.

Let me know if you hit any problems!
(Assignee)

Comment 6

3 years ago
Yes, my question was how to access the build machines? By SSH? Where can i see the IPs?
Flags: needinfo?(ted)
(Reporter)

Comment 7

3 years ago
Oh, sorry, I don't know how Thunderbird build machines are configured, I thought you had access.
Flags: needinfo?(ted)
(Reporter)

Comment 8

3 years ago
So uh, apparently I've been giving out misinformation here. I thought Thunderbird had its own separate builders, but I'm told that Thunderbird builds on the same pool of builders as Firefox. In that case, we can use the existing auth token file that Firefox is using. All we need to do here is ensure that the auth token bit is in the mozconfigs we're using, then. Sorry about that!
(Assignee)

Comment 9

3 years ago
In that case, I assume the patch in bug 1171218 is all we'll need.
(Reporter)

Comment 10

3 years ago
Assuming those same changes land on comm-central and not just the 38 branch, then yes, I think that should work.
(Reporter)

Comment 11

3 years ago
Yeah, so, this seems to be working on Linux/Mac trunk nightlies already:
https://treeherder.mozilla.org/logviewer.html#?job_id=19616&repo=comm-central shows:
```
Uploading symbol file "dist/thunderbird-41.0a1.en-US.linux-i686.crashreporter-symbols-full.zip" to "https://crash-stats.mozilla.com/symbols/upload"...
Uploaded successfully!
```

The linux64 and mac nightlies show the same thing. Windows nightlies are still using SSH though:
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2015/06/2015-06-07-03-02-20-comm-central/comm-central-win32-nightly-bm84-build1-build5.txt.gz has:
```
retry: Calling run_with_timeout with args: (['python.exe', 'c:/builds/moz2_slave/tb-c-cen-w32-ntly-000000000000/build/build/pymake/make.py', 'uploadsymbols'], 2460, None, None, False, True), kwargs: {}, attempt #1
Executing: ['python.exe', 'c:/builds/moz2_slave/tb-c-cen-w32-ntly-000000000000/build/build/pymake/make.py', 'uploadsymbols']
C:/mozilla-build/msys/bin/sh.exe c:/builds/moz2_slave/tb-c-cen-w32-ntly-000000000000/build/mozilla/toolkit/crashreporter/tools/upload_symbols.sh thunderbird-41.0a1-WINNT-20150607030220-x86-symbols.txt 'dist/thunderbird-41.0a1.en-US.win32.crashreporter-symbols-full.zip'
Transferring symbols... dist/thunderbird-41.0a1.en-US.win32.crashreporter-symbols-full.zip
```

It looks like the Win32 mozconfigs just didn't get the token file added. If you can fix that (you just need https://dxr.mozilla.org/mozilla-central/source/build/mozconfig.win-common#16 ), we can call this bug fixed.
(Assignee)

Comment 12

2 years ago
Apparently that part was added in bug 1171218, so -> FIXED
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 43.0
You need to log in before you can comment on or make changes to this bug.