Remove pin stripe AMO background and replace with gradient

VERIFIED FIXED

Status

VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: fpolizzi, Assigned: fpolizzi)

Tracking

(Blocks: 1 bug)

Details

(Assignee)

Description

3 years ago
This bug will be used to track updating the background of AMO to follow the sandstone style guide and create a more modern look.
(Assignee)

Updated

3 years ago
Assignee: nobody → fpolizzi
Fixed in https://github.com/mozilla/olympia/commit/9ecb505c69f652f2a15334376ee91c3eb8ca1814

Thanks fpolizzi!
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

3 years ago
New changes have been reflected here:
https://github.com/mozilla/olympia/pull/589

Updated

3 years ago
Depends on: 1178136

Comment 5

3 years ago
The background of AMO page is still the old one on FF39 Android 4.2.1.
Please see the screenshot: http://screencast.com/t/lCEErsl4rUnP
Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

3 years ago
(In reply to ValentinaP from comment #5)
> The background of AMO page is still the old one on FF39 Android 4.2.1.
> Please see the screenshot: http://screencast.com/t/lCEErsl4rUnP
> Reopening.

PR reflects changes on mobile:

https://github.com/mozilla/olympia/pull/618/files
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED

Comment 7

3 years ago
(In reply to fpolizzi from comment #6)
> PR reflects changes on mobile:
> https://github.com/mozilla/olympia/pull/618/files

But still, the changes cannot be seen on FF39(Android 4.2.1) on AMO-dev. :(
Please see the screenshots: http://screencast.com/t/eMpFGwtqrL4
Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Yeah, it shouldn't have been marked as resolved yet (it's not merged in master, so not visible on dev).
As soon as I merged the changes, i'll mark it as resolved again for you to verify ;)

Comment 9

3 years ago
(In reply to Mathieu Agopian [:magopian] from comment #8)
> Yeah, it shouldn't have been marked as resolved yet (it's not merged in
> master, so not visible on dev).
> As soon as I merged the changes, i'll mark it as resolved again for you to
> verify ;)

Deal!

Comment 10

3 years ago
Commit pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/652b6285babb659dd03af2bcad0a6d6b12a4e26e
Merge pull request #618 from FrancescoSTL/bug-1170302-Removing-pinstripe-mobile

Bug 1170302- Remove pinstripe for mobile
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED

Comment 11

3 years ago
Verified as fixed on FF39(Android 4.2.1)
Postfix screenshots: http://screencast.com/t/dIgo3zgR
Closing bug.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.