1170302 - Remove pin stripe AMO background and replace with gradient

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Francesco Polizzi [:fpolizzi]]

This bug will be used to track updating the background of AMO to follow the sandstone style guide and create a more modern look.

Comment 1

[Francesco Polizzi [:fpolizzi]]

Pull Request: https://github.com/mozilla/olympia/pull/574

Comment 2

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/9ecb505c69f652f2a15334376ee91c3eb8ca1814

Thanks fpolizzi!

Comment 3

[Francesco Polizzi [:fpolizzi]]

New changes have been reflected here:
https://github.com/mozilla/olympia/pull/589

Comment 4

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/6cf9f8bede4de121d3b29d4ede843263e187308d

Comment 5

[Valentina Virlics [:vvalentina], VPN QA]

The background of AMO page is still the old one on FF39 Android 4.2.1.
Please see the screenshot: http://screencast.com/t/lCEErsl4rUnP
Reopening.

Comment 6

[Francesco Polizzi [:fpolizzi]]

(In reply to ValentinaP from comment #5)
> The background of AMO page is still the old one on FF39 Android 4.2.1.
> Please see the screenshot: http://screencast.com/t/lCEErsl4rUnP
> Reopening.

PR reflects changes on mobile:

https://github.com/mozilla/olympia/pull/618/files

Comment 7

[Valentina Virlics [:vvalentina], VPN QA]

(In reply to fpolizzi from comment #6)
> PR reflects changes on mobile:
> https://github.com/mozilla/olympia/pull/618/files

But still, the changes cannot be seen on FF39(Android 4.2.1) on AMO-dev. :(
Please see the screenshots: http://screencast.com/t/eMpFGwtqrL4
Reopening.

Comment 8

[Mathieu Agopian [:magopian]]

Yeah, it shouldn't have been marked as resolved yet (it's not merged in master, so not visible on dev).
As soon as I merged the changes, i'll mark it as resolved again for you to verify ;)

Comment 9

[Valentina Virlics [:vvalentina], VPN QA]

(In reply to Mathieu Agopian [:magopian] from comment #8)
> Yeah, it shouldn't have been marked as resolved yet (it's not merged in
> master, so not visible on dev).
> As soon as I merged the changes, i'll mark it as resolved again for you to
> verify ;)

Deal!

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/652b6285babb659dd03af2bcad0a6d6b12a4e26e
Merge pull request #618 from FrancescoSTL/bug-1170302-Removing-pinstripe-mobile

Bug 1170302- Remove pinstripe for mobile

Comment 11

[Valentina Virlics [:vvalentina], VPN QA]

Verified as fixed on FF39(Android 4.2.1)
Postfix screenshots: http://screencast.com/t/dIgo3zgR
Closing bug.