117032 - "delete message on server" label needs to be clearer

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[basic]

From a comment in bug 66270  [RFE] Do not delete messages on POP server when
moved locally

<quote>
Confusion can be avoided without a dialog box by changing "Delete messages on
server when they are deleted locally" to "Leave messages on server as long as
they are in the inbox" or "Leave messages on server as long as they are filed
inside this account."
</quote>

We need a better label than "Delete messages on
server when they are deleted locally" as it also delete messages on
server when they are moved manually from the inbox.

Comment 1

[basic]

oops that should read:

We need a better label than "Delete messages on server when they are deleted
locally" as it <em>only</em> delete messages on server when they are moved
manually from the inbox.

Comment 2

[Sheela Ravindran]

Navin,
Since this is a pop perf I changing the assigned on this bug.  

Comment 3

[scottputterman]

moving out unless Jennifer or Robin thinks this needs to be changed.  nsbeta1 it
if you do.

Comment 4

[Sheela Ravindran]

See bug 140489 which also suggest that this pref needs more functionality. Also
there are other bugs with this pref that we don't apply this pref to work when
messages are filtered. (bug # 89034) Also keeping in mind that this will work
when you do a get message or if biff fires after the message is deleted.  
Nominating this for next release. 
Will wait for Jennifer to comment. 
Jennifer, 
Can you make your comments so that we resolve the bug based on that.  

Comment 5

[jglick]

Suggest changing the wording of "Delete messages on server when they are deleted 
locally" to "Delete messages on server when they are deleted or moved from my 
Inbox".

I commented in the other bugs mentioned as well.

Comment 6

[Navin Gupta]

Attachment: proposed fix

Increasing the width by 20 pixels did it for a new profile (made the text fit
on a single line).

Comment 7

[Navin Gupta]

bhuvan, david, Can I get reviews ? thx. 

Comment 8

[David :Bienvenu]

Comment on attachment 94689 [details] [diff] [review]
proposed fix

sr=bienvenu

Comment 9

[timeless]

Comment on attachment 94689 [details] [diff] [review]
proposed fix

>Index: en-US/AccountManager.dtd
>===================================================================
>RCS file: /cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/AccountManager.dtd,v
>retrieving revision 1.10
>diff -u -w -r1.10 AccountManager.dtd
>--- en-US/AccountManager.dtd	1 Mar 2002 23:35:52 -0000	1.10
>+++ en-US/AccountManager.dtd	9 Aug 2002 21:59:20 -0000
>@@ -17,5 +17,5 @@
>      panel content to fit. 1em = the width of the letter 'm' in the selected font.
>      XUL/FE DEVELOPERS: DO NOT MODIFY THIS VALUE. It represents the correct size of
>      this window for en-US. -->
PLEASE READ THE COMMENTS it says DO NOT MODIFY THIS VALUE.
>-<!ENTITY account-manager.width "620">
>+<!ENTITY account-manager.width "640">
> <!ENTITY account-manager.height "470">
you may not make this change.
>Index: en-US/am-server-top.dtd
>===================================================================
>RCS file: /cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/am-server-top.dtd,v
>retrieving revision 1.27
>diff -u -w -r1.27 am-server-top.dtd
>--- en-US/am-server-top.dtd	29 Jun 2001 08:18:21 -0000	1.27
>+++ en-US/am-server-top.dtd	9 Aug 2002 21:59:20 -0000
>@@ -22,7 +22,7 @@
> <!ENTITY biffEnd.label "minutes">
> <!ENTITY isSecure.label "Use secure connection (SSL)">
> <!ENTITY leaveOnServer.label "Leave messages on server">
>-<!ENTITY deleteOnServer.label "Delete messages on server when they are deleted locally">
>+<!ENTITY deleteOnServer.label "Delete messages on server when they are deleted or moved from my Inbox">
"my Inbox" we've already fought the battle of "my sidebar" there is no my.
Please remove my.
I'd suggest:

<!ENTITY deleteOnServer.label "Delete messages from server when they are
removed from Inbox">

Comment 10

[racham]

I think as long as we are in 640x480 limits and not reduce the existing sizes
(as it may crop some otems), we should be fine. 

Getting rid of 'my' is fine with me. Jennifer..?

Bhuvan

Comment 11

[jglick]

>Getting rid of 'my' is fine with me. Jennifer..?
Sure.

Comment 12

[Navin Gupta]

Attachment: patch -removed "my"

bhuvan, can you r ? thx.

Comment 13

[racham]

Comment on attachment 94702 [details] [diff] [review]
patch -removed "my"

r=bhuvan

Comment 14

[Navin Gupta]

fixed

Comment 15

[Sheela Ravindran]

Verified on commercial trunk builds:
win98-2002-09-11-10 
mac os x-2002-09-11-03
linux rh 6.2-2002-09-11-05 

The label is now changed to:"Delete messages on server when they are deleted or 
moved from Inbox".

From : "Delete messages on server when they are deleted locally"

This bug is being verified for the wording change only. 

Comment 16

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 167243 has been marked as a duplicate of this bug. ***