Closed Bug 1170375 Opened 5 years ago Closed 5 years ago

Add top Japanese sites to unprefixing service whitelist (part 4)

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
p11 + ---
firefox41 --- fixed

People

(Reporter: miketaylr, Assigned: miketaylr)

References

Details

(Whiteboard: [compat])

Attachments

(1 file, 1 obsolete file)

We have a few more sites to diagnose and need to make some tweaks to some existing sites.

To be added:

m.finance.yahoo.co.jp
s.yimg.jp

To be moved to IsOnBaseDomainWhitelist:

tsite.jp (needs s.tsite, img.tsite, tmall.tsite, etc).

I plan on finishing diagnosing the latest sites and writing a patch for this in the next day or so.
Assignee: nobody → miket
tracking-p11: --- → ?
See Also: → 1162245
Also:

weathernews.jp
cache.ymail.jp, // for www.yamada-denkiweb.com
img.travel.rakuten.co.jp", // for travel.rakuten.co.jp
Daniel, can you take a look?
Comment on attachment 8616157 [details] [diff] [review]
1170375-Add-4th-batch-of-top-.jp-sites-to-CSS-un.patch

r=me, just one nit:

>+++ b/caps/nsPrincipal.cpp
>@@ -457,25 +457,28 @@ IsOnFullDomainWhitelist(nsIURI* aURI)
>     NS_LITERAL_CSTRING("m.haosou.com"),
>     NS_LITERAL_CSTRING("m.mi.com"),
>     NS_LITERAL_CSTRING("wappass.baidu.com"),
>     NS_LITERAL_CSTRING("m.video.baidu.com"),
>     NS_LITERAL_CSTRING("m.video.baidu.com"),
>     NS_LITERAL_CSTRING("imgcache.gtimg.cn"), // for m.v.qq.com
>     NS_LITERAL_CSTRING("i.yimg.jp"), // for *.yahoo.co.jp
>     NS_LITERAL_CSTRING("ai.yimg.jp"), // for *.yahoo.co.jp
>+    NS_LITERAL_CSTRING("m.finance.yahoo.co.jp"),
[...]
>     NS_LITERAL_CSTRING("s.tabelog.jp"),
>+    NS_LITERAL_CSTRING("s.yimg.jp"), // for s.tabelog.jp

Let's move these two tabelog-related lines up higher, above "i.yimg.jp", so that we've got our $FOO.yimg.jp lines adjacent to each other.
Attachment #8616157 - Flags: review?(dholbert) → review+
Makes sense, will do. Thanks Daniel.
Updated to address nits and carrying forward r+.
Attachment #8616157 - Attachment is obsolete: true
No try run as we're just adding some domains to a whitelist (and building locally succeeds).
Keywords: checkin-needed
Whiteboard: [compat]
https://hg.mozilla.org/mozilla-central/rev/f39cc73b483b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
See Also: → 1166792
Blocks: 1162245
You need to log in before you can comment on or make changes to this bug.