Closed
Bug 1170375
Opened 9 years ago
Closed 9 years ago
Add top Japanese sites to unprefixing service whitelist (part 4)
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: miketaylr, Assigned: miketaylr)
References
Details
(Whiteboard: [compat])
Attachments
(1 file, 1 obsolete file)
4.01 KB,
patch
|
miketaylr
:
review+
|
Details | Diff | Splinter Review |
We have a few more sites to diagnose and need to make some tweaks to some existing sites. To be added: m.finance.yahoo.co.jp s.yimg.jp To be moved to IsOnBaseDomainWhitelist: tsite.jp (needs s.tsite, img.tsite, tmall.tsite, etc). I plan on finishing diagnosing the latest sites and writing a patch for this in the next day or so.
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Also: weathernews.jp cache.ymail.jp, // for www.yamada-denkiweb.com img.travel.rakuten.co.jp", // for travel.rakuten.co.jp
Assignee | ||
Comment 2•9 years ago
|
||
Daniel, can you take a look?
Comment 3•9 years ago
|
||
Comment on attachment 8616157 [details] [diff] [review] 1170375-Add-4th-batch-of-top-.jp-sites-to-CSS-un.patch r=me, just one nit: >+++ b/caps/nsPrincipal.cpp >@@ -457,25 +457,28 @@ IsOnFullDomainWhitelist(nsIURI* aURI) > NS_LITERAL_CSTRING("m.haosou.com"), > NS_LITERAL_CSTRING("m.mi.com"), > NS_LITERAL_CSTRING("wappass.baidu.com"), > NS_LITERAL_CSTRING("m.video.baidu.com"), > NS_LITERAL_CSTRING("m.video.baidu.com"), > NS_LITERAL_CSTRING("imgcache.gtimg.cn"), // for m.v.qq.com > NS_LITERAL_CSTRING("i.yimg.jp"), // for *.yahoo.co.jp > NS_LITERAL_CSTRING("ai.yimg.jp"), // for *.yahoo.co.jp >+ NS_LITERAL_CSTRING("m.finance.yahoo.co.jp"), [...] > NS_LITERAL_CSTRING("s.tabelog.jp"), >+ NS_LITERAL_CSTRING("s.yimg.jp"), // for s.tabelog.jp Let's move these two tabelog-related lines up higher, above "i.yimg.jp", so that we've got our $FOO.yimg.jp lines adjacent to each other.
Attachment #8616157 -
Flags: review?(dholbert) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Makes sense, will do. Thanks Daniel.
Assignee | ||
Comment 5•9 years ago
|
||
Updated to address nits and carrying forward r+.
Assignee | ||
Updated•9 years ago
|
Attachment #8616157 -
Attachment is obsolete: true
Assignee | ||
Comment 6•9 years ago
|
||
No try run as we're just adding some domains to a whitelist (and building locally succeeds).
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Whiteboard: [compat]
https://hg.mozilla.org/mozilla-central/rev/f39cc73b483b
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•