gecko: created timestamps are not UTC

RESOLVED FIXED

Status

Taskcluster
General
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jonasfj, Assigned: wcosta)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
As we found out on IRC today, created timestamps are in local time zone, and not UTC, when generated by in-tree. This is probably not a problem in the decision task because localtime = UTC on most sane servers.

See:
https://dxr.mozilla.org/mozilla-central/source/testing/taskcluster/mach_commands.py#157
https://dxr.mozilla.org/mozilla-central/source/testing/taskcluster/mach_commands.py#228

They should use `'now': current_json_time()` instead (it's already imported from taskcluster_graph.from_now.
(Assignee)

Updated

3 years ago
Assignee: nobody → wcosta
Status: NEW → ASSIGNED
Priority: -- → P1
(Assignee)

Comment 1

3 years ago
Created attachment 8614015 [details]
MozReview Request: Bug 1170378: Create tasks timestamps in UTC. r=jonasfj a=jonasfj

Bug 1170378: Create tasks timestamps in UTC. r=jonasfj a=jonasfj
Attachment #8614015 - Flags: review?(jopsen)
(Reporter)

Comment 2

3 years ago
https://reviewboard.mozilla.org/r/9833/#review8751

Looks good to me, r+
If it works on try, then it'll probably work in prod :)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8614015 [details]
MozReview Request: Bug 1170378: Create tasks timestamps in UTC. r=jonasfj a=jonasfj

I have no idea... what is up with review board, but I can't see any button that I'm supposed to push :)

Anyways, r+
Attachment #8614015 - Flags: review?(jopsen) → review+
https://hg.mozilla.org/mozilla-central/rev/23773d965ecc
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
status-firefox41: fixed → ---
Component: TaskCluster → General
Product: Testing → Taskcluster
Version: unspecified → Trunk
Resetting Version and Target Milestone that accidentally got changed...
Target Milestone: mozilla41 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.