1170380 - Try push triggered from ReviewBoard contains wrong changesets

Status: RESOLVED DUPLICATE of bug 1169898

(MozReview Graveyard :: General, defect)

Description

[Botond Ballo [:botond]]

I submitted a review request, followed the "review url" in the command-line output to get to the review request, and pressed "Trigger a try push".

However, the triggered Try push [2] contains the wrong commits. It appears to contain the commits from the previous version of the review request (which had just 2 commits) rather than the commits from the one I just pushed (which had 9 commits).

[1] https://reviewboard.mozilla.org/r/9513/
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=d72bbccfa043

Comment 1

[Dan Minor [:dminor]]

Is it possible that you had not yet published the review when you pressed 'Trigger a try push'? Pushing new commits would set it back to the 'draft' state so maybe the previously published commits were sent to Try rather than the new ones.

Comment 2

[Botond Ballo [:botond]]

(In reply to Dan Minor [:dminor] from comment #1)
> Is it possible that you had not yet published the review when you pressed
> 'Trigger a try push'? Pushing new commits would set it back to the 'draft'
> state so maybe the previously published commits were sent to Try rather than
> the new ones.

Yes, I triggered first and then published.

Am I to understand that triggering a try push does so on the last published version of the review, rather than the version I'm currently looking at?

Comment 3

[Dan Minor [:dminor]]

The 'Try' button should actually be disabled unless you've published the review, among other reasons to avoid problems like the one you encountered.