If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Share socket code in |ConnectionOrientedSocketIO| and helpers

RESOLVED FIXED in Firefox 41

Status

Firefox OS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

unspecified
2.2 S14 (12june)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(3 attachments)

|StreamSocketIO| and |BluetoothDaemonConnectionIO| contain a lot of duplicated I/O code. Most of this code can be shared in |ConnectionOrientedSocketIO|.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ac6067fd16a
Created attachment 8613923 [details] [diff] [review]
[01] Bug 1170466: Inherit |ConnectionOrientedSocketIO| from |UnixSocketWatcher|
Attachment #8613923 - Flags: review?(kyle)
Created attachment 8613924 [details] [diff] [review]
[02] Bug 1170466: Share socket I/O methods in |ConnectionOrientedSocketIO|
Attachment #8613924 - Flags: review?(kyle)
Created attachment 8613926 [details] [diff] [review]
[03] Bug 1170466: Implement accept and connect in |ConnectionOrientedSocketIO|
Attachment #8613926 - Flags: review?(kyle)
Attachment #8613923 - Flags: review?(kyle) → review+
Attachment #8613924 - Flags: review?(kyle) → review+
Attachment #8613926 - Flags: review?(kyle) → review+
Thanks!

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=eecddaa2cc3c

Comment 6

2 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/ef82cdf1079f
https://hg.mozilla.org/integration/b2g-inbound/rev/3bd34542b7c1
Blocks: 1170993
https://hg.mozilla.org/mozilla-central/rev/ef82cdf1079f
https://hg.mozilla.org/mozilla-central/rev/3bd34542b7c1
https://hg.mozilla.org/mozilla-central/rev/eecddaa2cc3c
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S14 (12june)
You need to log in before you can comment on or make changes to this bug.