1170520 - JavaScript Warning: "SyntaxError: unreachable code after return statement" {file: "resource://gre/modules/TelemetryStorage.jsm" ...

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

I am seeing this warning on a b2g build with the latest m-i

W/GeckoConsole(  206): [JavaScript Warning: "SyntaxError: unreachable code after return statement" {file: "resource://gre/modules/TelemetryStorage.jsm" line: 1267 column: 45 source: "      return (yield OS.File.stat(path)).size;;
W/GeckoConsole(  206): "}]

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 2

[Alessio Placitelli [:Dexter]]

Comment on attachment 8614009 [details] [diff] [review]
v1

Review of attachment 8614009 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for submitting this. Could you change the commit message a bit to something like "Bug XXX - Remove the redundant semi-colon in ..."

r=me with the changed commit message.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4d93e7f990a

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b4d93e7f990a

Comment 5

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8614009 [details] [diff] [review]
v1

1170520

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8614009 [details] [diff] [review]
v1

Unified telemetry is an important new feature. It is blocking some other projects. Taking it.

Comment 7

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5f544f1f1c63