Ensure to use pip to install dependencies via create_env.py

RESOLVED FIXED in Firefox 38

Status

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

41 Branch
mozilla41
Points:
---

Firefox Tracking Flags

(firefox38 fixed, firefox39 fixed, firefox40 fixed, firefox41 fixed, firefox-esr38 fixed)

Details

Attachments

(1 attachment)

Calling "python setup.py [develop|install]" will make use of setuptools to install the dependencies. Due to https://github.com/mozilla/mozmill-ci/issues/586 it would be good if pip would be used instead. To ensure that we only would have to replace the subprocess call with "pip install .". That should be totally sufficient for our CI and tester who only want to run the tests. They could always install the package in developer mode later.

We would need this fix across all branches.
Created attachment 8614103 [details] [review]
github_pull_request.txt
Attachment #8614103 - Flags: review?(jmaher)
Comment on attachment 8614103 [details] [review]
github_pull_request.txt

thanks, this looks great.
Attachment #8614103 - Flags: review?(jmaher) → review+
https://github.com/mozilla/firefox-ui-tests/commit/c51fdc3e6e71edbb579ab965acfbae19c32a41f4 (master)

Will backport once all works on master together with the other changesets.
status-firefox41: affected → fixed
Target Milestone: --- → Firefox 41
https://github.com/mozilla/firefox-ui-tests/commit/fbfa4d1563cd6af774cf52e647834c2e90987da0 (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/03bf871fe94d888f7c1d0c05dd10d469521f5b5d (beta, release)
https://github.com/mozilla/firefox-ui-tests/commit/483cb18edf31d438346a6cf58a56952df5cf9f35 (esr38)
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox38: affected → fixed
status-firefox39: affected → fixed
status-firefox40: affected → fixed
status-firefox-esr38: affected → fixed
Resolution: --- → FIXED
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.