fix race between document shutdown in child and parent sending messages

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(3 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8614108 [details] [diff] [review]
always use IdToAccessible to convert ids to accessibles
Attachment #8614108 - Flags: review?(lorien)
(Assignee)

Comment 2

3 years ago
Created attachment 8614109 [details] [diff] [review]
switch to sending __delete__ from the parent instead of the child
Attachment #8614109 - Flags: review?(dbolter)
Assignee: nobody → tbsaunde+mozbugs
Comment on attachment 8614109 [details] [diff] [review]
switch to sending __delete__ from the parent instead of the child

Review of attachment 8614109 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Thanks for IRC'ing. (__delete__ is still a bit of mysterious to me)

::: accessible/ipc/DocAccessibleChild.h
@@ +33,5 @@
>    ~DocAccessibleChild()
>    {
> +    MOZ_ASSERT(!mDoc);
> +    if (mDoc)
> +      mDoc->SetIPCDoc(nullptr);

nit: If you have any hunches why we need this maybe add a comment?
Attachment #8614109 - Flags: review?(dbolter) → review+

Updated

3 years ago
Attachment #8614108 - Flags: review?(lorien) → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8615992 [details] [diff] [review]
only send __delete__ from DocAccessibleParent if the tab isn't destroyed
Attachment #8615992 - Flags: review?(bugs)

Comment 5

3 years ago
Comment on attachment 8615992 [details] [diff] [review]
only send __delete__ from DocAccessibleParent if the tab isn't destroyed

> DocAccessibleParent::RecvShutdown()
> {
>   Destroy();
>+
>+  if (!static_cast<dom::TabParent*>(Manager())->IsDestroyed()) {
>   return PDocAccessibleParent::Send__delete__(this);
Missing 2 space indentation for the return
Attachment #8615992 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/33283f55d8ef
https://hg.mozilla.org/mozilla-central/rev/78fc82c0601a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.