1170596 - IonGraph not working anymore on functions which contain infinite loops

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

I've tried both IONFLAGS=logs, and IONFLAGS=logs-sync with --ion-offthread-compile=off, without success. The smallest test case I have is a function which contains an infinite loop:


function module() {
    'use asm';
    function f() {
        var x = 42;
        while ((x|0) > 32) {
        }
    }
    return f;
};
module()();

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Always flush after any write.

This is a work-around, I will try to come with a cleaner patch, as we
probably don't want to flsuh all the time.

Comment 2

[Nicolas B. Pierron [:nbp]]

Attachment: JitSpewer: Always flush after dumping the graph to the files.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8614124 [details] [diff] [review]
JitSpewer: Always flush after dumping the graph to the files.

Review of attachment 8614124 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! It fixed the issue I saw when debugging a rather large asm.js module.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f58aadb6c75e

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f58aadb6c75e