IonGraph not working anymore on functions which contain infinite loops

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bbouvier, Assigned: nbp)

Tracking

unspecified
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

I've tried both IONFLAGS=logs, and IONFLAGS=logs-sync with --ion-offthread-compile=off, without success. The smallest test case I have is a function which contains an infinite loop:


function module() {
    'use asm';
    function f() {
        var x = 42;
        while ((x|0) > 32) {
        }
    }
    return f;
};
module()();
(Assignee)

Comment 1

4 years ago
Created attachment 8614123 [details] [diff] [review]
Always flush after any write.

This is a work-around, I will try to come with a cleaner patch, as we
probably don't want to flsuh all the time.
(Assignee)

Comment 2

4 years ago
Created attachment 8614124 [details] [diff] [review]
JitSpewer: Always flush after dumping the graph to the files.
Attachment #8614124 - Flags: review?(benj)
(Assignee)

Updated

4 years ago
Attachment #8614123 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Assignee: nobody → nicolas.b.pierron
Comment on attachment 8614124 [details] [diff] [review]
JitSpewer: Always flush after dumping the graph to the files.

Review of attachment 8614124 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! It fixed the issue I saw when debugging a rather large asm.js module.
Attachment #8614124 - Flags: review?(benj) → review+
https://hg.mozilla.org/mozilla-central/rev/f58aadb6c75e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.