Closed Bug 1170596 Opened 7 years ago Closed 7 years ago

IonGraph not working anymore on functions which contain infinite loops

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: bbouvier, Assigned: nbp)

Details

Attachments

(1 file, 1 obsolete file)

I've tried both IONFLAGS=logs, and IONFLAGS=logs-sync with --ion-offthread-compile=off, without success. The smallest test case I have is a function which contains an infinite loop:


function module() {
    'use asm';
    function f() {
        var x = 42;
        while ((x|0) > 32) {
        }
    }
    return f;
};
module()();
Attached patch Always flush after any write. (obsolete) — Splinter Review
This is a work-around, I will try to come with a cleaner patch, as we
probably don't want to flsuh all the time.
Attachment #8614123 - Attachment is obsolete: true
Assignee: nobody → nicolas.b.pierron
Comment on attachment 8614124 [details] [diff] [review]
JitSpewer: Always flush after dumping the graph to the files.

Review of attachment 8614124 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! It fixed the issue I saw when debugging a rather large asm.js module.
Attachment #8614124 - Flags: review?(benj) → review+
https://hg.mozilla.org/mozilla-central/rev/f58aadb6c75e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.