Closed Bug 1170632 Opened 5 years ago Closed 5 years ago

Enable chunk-by-runtime for Mochitest-browser-chrome

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgriffin, Assigned: jgriffin)

Details

Attachments

(3 files)

No description provided.
opt looks good, guess I should try debug too: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a0ffd0b262a
Debug looks good too
Attachment #8614325 - Flags: review?(ahalberstadt)
Comment on attachment 8614325 [details] [diff] [review]
Enable chunk-by-runtime for mbc,

Review of attachment 8614325 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm! Fyi, it's probably not necessary to create a separate "chunked" variant as --chunk-by-runtime is basically a no-op if options.totalChunks is in (None, 1). But I guess splitting it makes intentions more explicit and is probably more future-proof.
Attachment #8614325 - Flags: review?(ahalberstadt) → review+
(In reply to Andrew Halberstadt [:ahal] from comment #4)
> Comment on attachment 8614325 [details] [diff] [review]
> Enable chunk-by-runtime for mbc,
> 
> Review of attachment 8614325 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Lgtm! Fyi, it's probably not necessary to create a separate "chunked"
> variant as --chunk-by-runtime is basically a no-op if options.totalChunks is
> in (None, 1). But I guess splitting it makes intentions more explicit and is
> probably more future-proof.

Thanks, good to know.  I'll things as-is for now, primarily because I don't want to have to coordinate a buildbot-configs change at the same time.
I had to back this out, since it caused linux-asan failures with the message:

11:55:18 INFO - IOError: [Errno 2] No such file or directory: '/builds/slave/test/build/tests/mochitest/runtimes/linux64-asan/mochitest-e10s-browser-chrome.runtimes.json' 

Ahal, do we have an easy way to generate these?  If not, I can look at using ActiveData to do it.
Flags: needinfo?(ahalberstadt)
The other ones were generated by a one-off pulse listener I created:
https://github.com/ahal/runtime-accumulator

You can look into it, but the process is a little involved, it might be more worthwhile to try and use active data.

But if you want to try..

1. Clone and install runtime-accumulator
2. Add the asan build to PLATFORMS:
https://github.com/ahal/runtime-accumulator/blob/master/runtimes/config.py#L124

3. Create a file called ~/.runtimes.ini with the following:
https://pastebin.mozilla.org/8835608

4. Have a mongodb server running on localhost:27017 (the default)
5. Start collecting runtime data (I let it run for a few hours, make sure inbound isn't closed):
accumulate-runtimes --log-mach -

6. Kill the listener and generate runtime data:
generate-runtimes --gen.outdir path/to/testing/runtimes --gen.percentile 90

The percentile thing means only 10% of the files will actually be stored. I think that's everything..
Flags: needinfo?(ahalberstadt)
Ok, I'll try the ActiveData approach.
Attachment #8615411 - Flags: review?(ahalberstadt)
Comment on attachment 8615411 [details] [diff] [review]
Add missing runtimes for mochitest-bc,

Review of attachment 8615411 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm! Bonus points if you update the existing ones too :) (though that's obvious follow-up fodder if it's a hassle).
Attachment #8615411 - Flags: review?(ahalberstadt) → review+
(In reply to Andrew Halberstadt [:ahal] from comment #12)
> Comment on attachment 8615411 [details] [diff] [review]
> Add missing runtimes for mochitest-bc,
> 
> Review of attachment 8615411 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Lgtm! Bonus points if you update the existing ones too :) (though that's
> obvious follow-up fodder if it's a hassle).

Still working on the ActiveData queries to make this easy and automatic, so I'll do that as a follow-up.
Keywords: leave-open
Re-landed mozharness change:  https://hg.mozilla.org/build/mozharness/rev/b2bb5eaad3cb

Will perform a mozharness bump on m-c instead of m-i, per Ryan's request.
Comment on attachment 8616296 [details] [diff] [review]
Fix platform_guess for osx; add pgo runtimes for mbc,

Review of attachment 8616296 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8616296 - Flags: review?(ahalberstadt) → review+
...and linux64-pgo runtimes (missed earlier):  https://hg.mozilla.org/mozilla-central/rev/a7913ddbdd70
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.