Closed
Bug 1170632
Opened 9 years ago
Closed 9 years ago
Enable chunk-by-runtime for Mochitest-browser-chrome
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jgriffin, Assigned: jgriffin)
Details
Attachments
(3 files)
3.47 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
38.87 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
6.73 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9896b9d7a17d
Assignee | ||
Comment 2•9 years ago
|
||
opt looks good, guess I should try debug too: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a0ffd0b262a
Assignee | ||
Comment 3•9 years ago
|
||
Debug looks good too
Attachment #8614325 -
Flags: review?(ahalberstadt)
Comment 4•9 years ago
|
||
Comment on attachment 8614325 [details] [diff] [review] Enable chunk-by-runtime for mbc, Review of attachment 8614325 [details] [diff] [review]: ----------------------------------------------------------------- Lgtm! Fyi, it's probably not necessary to create a separate "chunked" variant as --chunk-by-runtime is basically a no-op if options.totalChunks is in (None, 1). But I guess splitting it makes intentions more explicit and is probably more future-proof.
Attachment #8614325 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #4) > Comment on attachment 8614325 [details] [diff] [review] > Enable chunk-by-runtime for mbc, > > Review of attachment 8614325 [details] [diff] [review]: > ----------------------------------------------------------------- > > Lgtm! Fyi, it's probably not necessary to create a separate "chunked" > variant as --chunk-by-runtime is basically a no-op if options.totalChunks is > in (None, 1). But I guess splitting it makes intentions more explicit and is > probably more future-proof. Thanks, good to know. I'll things as-is for now, primarily because I don't want to have to coordinate a buildbot-configs change at the same time.
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/build/mozharness/rev/9254988b2496
Assignee | ||
Comment 7•9 years ago
|
||
mozharness bump: https://hg.mozilla.org/integration/mozilla-inbound/rev/ca0d8c5301be
Assignee | ||
Comment 8•9 years ago
|
||
I had to back this out, since it caused linux-asan failures with the message: 11:55:18 INFO - IOError: [Errno 2] No such file or directory: '/builds/slave/test/build/tests/mochitest/runtimes/linux64-asan/mochitest-e10s-browser-chrome.runtimes.json' Ahal, do we have an easy way to generate these? If not, I can look at using ActiveData to do it.
Flags: needinfo?(ahalberstadt)
Comment 9•9 years ago
|
||
The other ones were generated by a one-off pulse listener I created: https://github.com/ahal/runtime-accumulator You can look into it, but the process is a little involved, it might be more worthwhile to try and use active data. But if you want to try.. 1. Clone and install runtime-accumulator 2. Add the asan build to PLATFORMS: https://github.com/ahal/runtime-accumulator/blob/master/runtimes/config.py#L124 3. Create a file called ~/.runtimes.ini with the following: https://pastebin.mozilla.org/8835608 4. Have a mongodb server running on localhost:27017 (the default) 5. Start collecting runtime data (I let it run for a few hours, make sure inbound isn't closed): accumulate-runtimes --log-mach - 6. Kill the listener and generate runtime data: generate-runtimes --gen.outdir path/to/testing/runtimes --gen.percentile 90 The percentile thing means only 10% of the files will actually be stored. I think that's everything..
Flags: needinfo?(ahalberstadt)
Assignee | ||
Comment 10•9 years ago
|
||
Ok, I'll try the ActiveData approach.
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8615411 -
Flags: review?(ahalberstadt)
Comment 12•9 years ago
|
||
Comment on attachment 8615411 [details] [diff] [review] Add missing runtimes for mochitest-bc, Review of attachment 8615411 [details] [diff] [review]: ----------------------------------------------------------------- Lgtm! Bonus points if you update the existing ones too :) (though that's obvious follow-up fodder if it's a hassle).
Attachment #8615411 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 13•9 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #12) > Comment on attachment 8615411 [details] [diff] [review] > Add missing runtimes for mochitest-bc, > > Review of attachment 8615411 [details] [diff] [review]: > ----------------------------------------------------------------- > > Lgtm! Bonus points if you update the existing ones too :) (though that's > obvious follow-up fodder if it's a hassle). Still working on the ActiveData queries to make this easy and automatic, so I'll do that as a follow-up.
Assignee | ||
Updated•9 years ago
|
Keywords: leave-open
Assignee | ||
Comment 16•9 years ago
|
||
Re-landed mozharness change: https://hg.mozilla.org/build/mozharness/rev/b2bb5eaad3cb Will perform a mozharness bump on m-c instead of m-i, per Ryan's request.
Assignee | ||
Comment 17•9 years ago
|
||
mozharness bump: https://hg.mozilla.org/mozilla-central/rev/b0315d00af9e
Comment 18•9 years ago
|
||
(In reply to Jonathan Griffin (:jgriffin) from comment #17) > mozharness bump: https://hg.mozilla.org/mozilla-central/rev/b0315d00af9e Backed out for OSX bustage. https://treeherder.mozilla.org/logviewer.html#?job_id=1612776&repo=mozilla-central https://hg.mozilla.org/mozilla-central/rev/555c96db9c33
Comment 19•9 years ago
|
||
linux64 pgo broke as well https://treeherder.mozilla.org/logviewer.html#?job_id=1612957&repo=mozilla-central
Assignee | ||
Comment 20•9 years ago
|
||
Attachment #8616296 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 21•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=31f755f1b010
Comment 22•9 years ago
|
||
Comment on attachment 8616296 [details] [diff] [review] Fix platform_guess for osx; add pgo runtimes for mbc, Review of attachment 8616296 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8616296 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 26•9 years ago
|
||
...and linux64-pgo runtimes (missed earlier): https://hg.mozilla.org/mozilla-central/rev/a7913ddbdd70
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 29•6 years ago
|
||
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•