Closed
Bug 1170634
Opened 10 years ago
Closed 10 years ago
Pre-commit and our dependencies are getting mixed in Travis, causing failures.
Categories
(support.mozilla.org :: Code Quality, task, P1)
support.mozilla.org
Code Quality
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mythmon, Assigned: rehandalal+mozilla)
Details
(Whiteboard: u=dev p=1 s=2015.10)
Lately Travis builds (specifically lint builds) have been failing because pre-commit tries to install its own set of dependencies, including flake8. We have a conflicting version of some of these deps in our requirements file.
I think this is happening because Travis doesn't use a virtualenv.
We could probably fix this by simply removing flake8 and friends from our requirements/dev.txt. We don't use it directly anymore, as far as I know.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rdalal
Assignee | ||
Comment 1•10 years ago
|
||
Making this a 1pt'er
Whiteboard: u=dev p=? s= → u=dev p=1 s=2015.10
Assignee | ||
Comment 2•10 years ago
|
||
Landed:
https://github.com/mozilla/kitsune/commit/997e44f4caf855ac2b77c0f1f799649a77d94697
https://github.com/mozilla/kitsune/commit/66424dd87e653685272a37f29307394e10aff089
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 3•10 years ago
|
||
This should have been a P1 since it was blocking other work.
Priority: -- → P1
You need to log in
before you can comment on or make changes to this bug.
Description
•