Closed Bug 1170658 Opened 5 years ago Closed 5 years ago

[Music] [Front-end] Add unit tests for ui/title_bar.js

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S3 (24Jul)

People

(Reporter: dkuo, Assigned: hub)

References

Details

Attachments

(1 file)

Currently ui/title_bar.js lacks for the unit tests so let's add them.
PR depends on the other one (hence the two commits)
Assignee: nobody → hub
Status: NEW → ASSIGNED
Attachment #8629211 - Flags: review?(dkuo)
Comment on attachment 8629211 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30813

cancelling review. need to rework too.
Attachment #8629211 - Flags: review?(dkuo)
Attachment #8629211 - Flags: review?(dkuo)
Blocks: 1170637
Blocks: 1170647
Test needs fixing after rebasing.
Should be fixed now. Changes in the LazyLoader calling were the reason.
Comment on attachment 8629211 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30813

Switching review over to Jim.
Attachment #8629211 - Flags: review?(dkuo) → review?(squibblyflabbetydoo)
Comment on attachment 8629211 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30813

r+ with one comment on GitHub.
Attachment #8629211 - Flags: review?(squibblyflabbetydoo) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S3 (24Jul)
You need to log in before you can comment on or make changes to this bug.