Closed
Bug 1170658
Opened 9 years ago
Closed 9 years ago
[Music] [Front-end] Add unit tests for ui/title_bar.js
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S3 (24Jul)
People
(Reporter: dkuo, Assigned: hub)
References
Details
Attachments
(1 file)
Currently ui/title_bar.js lacks for the unit tests so let's add them.
Assignee | ||
Comment 1•9 years ago
|
||
PR depends on the other one (hence the two commits)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8629211 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30813 cancelling review. need to rework too.
Attachment #8629211 -
Flags: review?(dkuo)
Assignee | ||
Updated•9 years ago
|
Attachment #8629211 -
Flags: review?(dkuo)
Assignee | ||
Comment 3•9 years ago
|
||
Test needs fixing after rebasing.
Assignee | ||
Comment 4•9 years ago
|
||
Should be fixed now. Changes in the LazyLoader calling were the reason.
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8629211 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30813 Switching review over to Jim.
Attachment #8629211 -
Flags: review?(dkuo) → review?(squibblyflabbetydoo)
Comment 6•9 years ago
|
||
Comment on attachment 8629211 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30813 r+ with one comment on GitHub.
Attachment #8629211 -
Flags: review?(squibblyflabbetydoo) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Merged https://github.com/mozilla-b2g/gaia/commit/7382237743b1156a82aaf73e6860e38d3cf26a04
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Target Milestone: --- → FxOS-S3 (24Jul)
You need to log in
before you can comment on or make changes to this bug.
Description
•