Red warning "not for your platform" flashes briefly when I click to app details page

RESOLVED FIXED

Status

Marketplace
Consumer Pages
P4
minor
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: c8o, Assigned: ankursmooth, Mentored)

Tracking

Avenir
Points:
---

Details

(Whiteboard: [ktlo], [good first bug])

(Reporter)

Description

3 years ago
I pull up marketplace on desktop production

I click on any app on the homepage
(tried: Wordpress, Tapthebest, Road Crossing)

When the page loads I see the red "not available for your platform" message flash on the screen quickly and then it goes away

Expected: the red warning message should not be visible at all as the app details page loads


(on a mac, firefox 38.0.5)
Severity: normal → minor
Priority: -- → P4
Whiteboard: [ktlo]

Comment 1

3 years ago
A placeholder_app is set in apps/views.js which is sent to templates/app/index.html which renders detail_header from _macros/detail.html which sends a placeholder app into app_tile.html in _macros/app_tile.html.

Make app_tile.html not render the message while it's rendering the placeholder app.
Whiteboard: [ktlo] → [ktlo], [good first bug]
(Assignee)

Comment 2

3 years ago
hey can i try solve this bug

Comment 3

3 years ago
(In reply to ankursmooth from comment #2)
> hey can i try solve this bug

Hey Can i Try to fix it if you are not doing ?
(Assignee)

Comment 4

3 years ago
(In reply to ankursmooth from comment #2)
> hey can i try solve this bug
Flags: needinfo?(trishul.goel)

Comment 5

3 years ago
if both of u are not doing it, shall I proceed?
Assigning this to Ayush, Thanks
Assignee: nobody → ankursmooth
Status: NEW → ASSIGNED
Flags: needinfo?(trishul.goel)
(In reply to Ram Dayal Vaishnav [:ramd] from comment #6)
> Assigning this to Ayush, Thanks

Assigned this to Ankur, sorry for typo.
(Assignee)

Updated

3 years ago
Flags: needinfo?(kngo)
Hi Ankur, if you need any specific please mention here while raising the needinfo flag. Clearing the flag for now, feel free to raise the flag or catch engineers on #marketplace on irc.mozilla.org for any help.
Flags: needinfo?(kngo)
Mentor: mstriemer
You should be able to set `notices = []` in [1] if the app's slug in `loading` (which comes from [2]).

> {% set notices = [] if app.slug == 'loading' else app_notices(app) %}

[1] https://github.com/mozilla/fireplace/blob/65a024b449d981e9019f1eabbf2ed4f70491a45a/src/templates/_macros/app_tile.html#L71
[2] https://github.com/mozilla/fireplace/blob/65a024b449d981e9019f1eabbf2ed4f70491a45a/src/media/js/views/app.js#L35
(Assignee)

Comment 10

3 years ago
thanks Mark Striemer[:mstriemer].
i have done it and tested it.
please look into pull request number #1456
Flags: needinfo?(mstriemer)
https://github.com/mozilla/fireplace/commit/3050f509707391b1497c0ef24ee1d00ec20dd4c7
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(mstriemer)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.