Closed Bug 1170691 Opened 6 years ago Closed 6 years ago

use GENERATED_FILES in toolkit/components/telemetry/

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(2 files)

No description provided.
The patch is mostly noise from using function-style print in the scripts, but
ideally the intent should be pretty clear.
Attachment #8614225 - Flags: review?(mshal)
Comment on attachment 8614225 [details] [diff] [review]
use GENERATED_FILES in toolkit/components/telemetry/

Argh, now we can't import modules from the srcdir.  Canceling review for the moment.
Attachment #8614225 - Flags: review?(mshal)
The old way of writing scripts for generated files would invoke the script thusly:

    python script.py arg1...

Invoking the script this way means that the script's directory is
automatically added to sys.path, and importing modules from that
directory is easy.  Let's make it equally easy in the new world for
GENERATED_FILES, too.
Attachment #8614262 - Flags: review?(mshal)
Comment on attachment 8614225 [details] [diff] [review]
use GENERATED_FILES in toolkit/components/telemetry/

mshal isn't doing reviews at this point, so picking on glandium.
Attachment #8614225 - Flags: review?(mh+mozilla)
Comment on attachment 8614262 [details] [diff] [review]
part 1 - add the generating script's directory to sys.path in file_generate.py

mshal isn't doing reviews at this point, so picking on glandium.
Attachment #8614262 - Flags: review?(mshal) → review?(mh+mozilla)
Comment on attachment 8614225 [details] [diff] [review]
use GENERATED_FILES in toolkit/components/telemetry/

Review of attachment 8614225 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/moz.build
@@ +57,5 @@
>  ]
>  
> +histogram_files = [
> +    SRCDIR + '/Histograms.json',
> +    TOPSRCDIR + '/dom/base/UseCounters.conf',

Rebase on top of bug 1170431
Attachment #8614225 - Flags: review?(mh+mozilla) → review+
Attachment #8614262 - Flags: review?(mh+mozilla) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.