use GENERATED_FILES in toolkit/components/telemetry/

RESOLVED FIXED in Firefox 41

Status

RESOLVED FIXED
3 years ago
8 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla41

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8614225 [details] [diff] [review]
use GENERATED_FILES in toolkit/components/telemetry/

The patch is mostly noise from using function-style print in the scripts, but
ideally the intent should be pretty clear.
Attachment #8614225 - Flags: review?(mshal)
(Assignee)

Comment 2

3 years ago
Comment on attachment 8614225 [details] [diff] [review]
use GENERATED_FILES in toolkit/components/telemetry/

Argh, now we can't import modules from the srcdir.  Canceling review for the moment.
Attachment #8614225 - Flags: review?(mshal)
(Assignee)

Comment 3

3 years ago
Created attachment 8614262 [details] [diff] [review]
part 1 - add the generating script's directory to sys.path in file_generate.py

The old way of writing scripts for generated files would invoke the script thusly:

    python script.py arg1...

Invoking the script this way means that the script's directory is
automatically added to sys.path, and importing modules from that
directory is easy.  Let's make it equally easy in the new world for
GENERATED_FILES, too.
Attachment #8614262 - Flags: review?(mshal)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8614225 [details] [diff] [review]
use GENERATED_FILES in toolkit/components/telemetry/

mshal isn't doing reviews at this point, so picking on glandium.
Attachment #8614225 - Flags: review?(mh+mozilla)
(Assignee)

Comment 5

3 years ago
Comment on attachment 8614262 [details] [diff] [review]
part 1 - add the generating script's directory to sys.path in file_generate.py

mshal isn't doing reviews at this point, so picking on glandium.
Attachment #8614262 - Flags: review?(mshal) → review?(mh+mozilla)
Comment on attachment 8614225 [details] [diff] [review]
use GENERATED_FILES in toolkit/components/telemetry/

Review of attachment 8614225 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/moz.build
@@ +57,5 @@
>  ]
>  
> +histogram_files = [
> +    SRCDIR + '/Histograms.json',
> +    TOPSRCDIR + '/dom/base/UseCounters.conf',

Rebase on top of bug 1170431
Attachment #8614225 - Flags: review?(mh+mozilla) → review+
Attachment #8614262 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/b1aec9026884
https://hg.mozilla.org/mozilla-central/rev/282f50513dd4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.