Back/forward history breaks with anchor URLs

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bnicholson, Assigned: bmunar)

Tracking

unspecified
All
iOS

Firefox Tracking Flags

(fennec+, fxios+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
STR:
1) Go to https://people.mozilla.org/~bnicholson/test/fragmenturl.html
2) Click the link
3) Click back twice
4) Click forward repeatedly

The forward button never deactivates.
(Reporter)

Updated

3 years ago
Assignee: nobody → bmunar
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8614441 [details] [review]
Pull Request
(Assignee)

Comment 2

3 years ago
Comment on attachment 8614441 [details] [review]
Pull Request

>https://github.com/mozilla/firefox-ios/pull/545
Attachment #8614441 - Flags: review?(bnicholson)
tracking-fennec: ? → +
tracking-fxios: --- → +
(Reporter)

Comment 3

3 years ago
Comment on attachment 8614441 [details] [review]
Pull Request

Looks good with nits cleaned up.
Attachment #8614441 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8616090 [details] [review]
PR
Attachment #8616090 - Flags: review?(bnicholson)
(Reporter)

Comment 5

3 years ago
Comment on attachment 8616090 [details] [review]
PR

Note that since the PR attachment is already here, you can just edit the existing attachment by flipping r+ -> r? without creating a new attachment.
Attachment #8616090 - Attachment is obsolete: true
Attachment #8616090 - Flags: review?(bnicholson)
(Reporter)

Updated

3 years ago
Attachment #8614441 - Flags: review+ → review?(bnicholson)
(Reporter)

Updated

3 years ago
Attachment #8614441 - Flags: review?(bnicholson) → review+
(Reporter)

Comment 6

3 years ago
https://github.com/mozilla/firefox-ios/commit/01bce837c5d4c83ee4a9f8b283cc060a20df5f5b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Depends on: 1173203
You need to log in before you can comment on or make changes to this bug.