1170727 - Consolidate all Response classes in various tests

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Peter Bengtsson [:peterbe]]

We have accidentally bloated to repeated definitions of the mocking utility to fake a HTTP response. 
Doing a grep for `class Response` gives:

airmozilla/auth/tests/test_views.py:90:class Response(object):
airmozilla/base/tests/test_mozillians.py:249:class Response(object):
airmozilla/base/tests/test_utils.py:12:class Response(object):
airmozilla/comments/tests/test_views.py:65:class Response(object):
airmozilla/manage/tests/test_autocompeter.py:18:class Response(object):
airmozilla/suggest/tests/test_utils.py:16:class Response(object):
airmozilla/suggest/tests/test_views.py:42:class Response(object):


Some of them are slightly different so it might not just be a matter of replacing them all with a `from airmozilla.base.tests.testbase import Response`.

Comment 1

[Alex Buck]

Hi Peter I had a go at this one and submitted a pull request on github. I left some comments in there on what I did. Thanks

https://github.com/mozilla/airmozilla/pull/340

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/9682396bd7de8e9f8a158de722630b7cc272f216
fixes bug 1170727 - Removing Response class duplication in tests

https://github.com/mozilla/airmozilla/commit/5c537e4712095a0df61c49cb16d04790a9f692c6
Merge pull request #340 from a-buck/bug1170727

fixes bug 1170727 - Removing Response class duplication in tests