Closed
Bug 1170736
Opened 9 years ago
Closed 9 days ago
AMO Non-Firefox Add-on Download Button (tracking)
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
2015-08
People
(Reporter: fpolizzi, Assigned: fpolizzi)
References
Details
Attachments
(3 files)
This bug will be used to track the changes to the add-on download button for non-firefox users to contain a direct FF download.
Assignee | ||
Comment 1•9 years ago
|
||
(In reply to fpolizzi from comment #0) > This bug will be used to track the changes to the add-on download button for > non-firefox users to contain a direct FF download. pull request: https://github.com/mozilla/olympia/pull/575
Updated•9 years ago
|
Assignee: nobody → fpolizzi
Comment 2•9 years ago
|
||
We need to add UTM parameters to the button. For this line: $button.attr('href', 'https://www.mozilla.org/firefox/new/?scene=2#download-fx'); Change it to: $button.attr('href', 'https://www.mozilla.org/firefox/new/?scene=2&utm_source=addons.mozilla.org&utm_medium=referral&utm_campaign=non-fx-button#download-fx');
Comment 3•9 years ago
|
||
Fixed in https://github.com/mozilla/olympia/commit/1db0172bf4439705ce648e3026d29b29905b53de Thanks fpolizzi!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 4•9 years ago
|
||
STR: 1. Open https://addons.mozilla.org/en-US/firefox/addon/night-mode-page-dim/?src=hp-dl-upandcoming on Chrome expected behavior: There is only one download button observed behavior: For add-ons which have platform-specific files, there are 3 buttons
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 5•9 years ago
|
||
I reverted the commit for now in https://github.com/mozilla/olympia/commit/23714db1debc55ab6a2119ec14dffd13735bd5fb
Assignee | ||
Comment 6•9 years ago
|
||
The fixes are now reflected on this pull request: https://github.com/mozilla/olympia/pull/588
Assignee | ||
Comment 7•9 years ago
|
||
I've found another issue with the last pull. Looks like the button is being used for collections and the longer text is making it break out of the parent div. I'm having trouble doing QA on my local version without having live data populated in AMO.
Assignee | ||
Comment 8•9 years ago
|
||
(In reply to fpolizzi from comment #7) > I've found another issue with the last pull. Looks like the button is being > used for collections and the longer text is making it break out of the > parent div. I'm having trouble doing QA on my local version without having > live data populated in AMO. The bug can be seen here: https://addons-dev.allizom.org/en-US/firefox/collections/mozilla/webdeveloper/
Updated•9 years ago
|
Assignee | ||
Comment 9•9 years ago
|
||
Fixed button overflow issue in item-info div with newest PR: https://github.com/mozilla/olympia/pull/595
Comment 10•9 years ago
|
||
Fixed in https://github.com/mozilla/olympia/commit/ac7c446cb0b630c768d2f42f58b0a22609ee8981 Thanks Francesco!
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•9 years ago
|
||
It has come to our attention that SeaMonkey users are currently unable to download any addons on AMO, however, there are many addons which are supported for SeaMonkey on AMO. We are seeking to filter SeaMonkey users from seeing this Non-fx download button, and adding a "download anyway" link beneath the button in order to cover any other cases in which a user would like to download an addon on a non-firefox web browser.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 12•9 years ago
|
||
Additionally, for pure aesthetic reasons, we would like to change the "--" in the download button to a single em dash.
Comment 13•9 years ago
|
||
I think the previous solution was good - enabled download and disabled direct installation.
Comment 14•9 years ago
|
||
@Comment11: No, that's not quite correct. It is about Firefox-only add-ons only. SM-add-ons are downloadable but from the SM sector of AMO only. But, I often download Firefox-only add-ons because I help Firefox users in a forum. I have to start Firefox now to download Firefox-only add-ons.
Assignee | ||
Comment 15•9 years ago
|
||
(In reply to Michael Wolf from comment #14) > @Comment11: No, that's not quite correct. It is about Firefox-only add-ons > only. SM-add-ons are downloadable but from the SM sector of AMO only. But, I > often download Firefox-only add-ons because I help Firefox users in a forum. > I have to start Firefox now to download Firefox-only add-ons. Ah, understood. It seems as though the best way to work around this is to add a "download anyway" link below the current download button. This would allow for any user to download the add-on no matter what browser they were using, while also allowing for the current call-to-action to exist within the page.
Comment 16•9 years ago
|
||
Yes, it was the old status quo until now as I wrote in comment #13.
Assignee | ||
Comment 17•9 years ago
|
||
I've made a pull request to fix this issue.
Comment 18•9 years ago
|
||
PR: https://github.com/mozilla/olympia/pull/646
Comment 19•9 years ago
|
||
Fixed in https://github.com/mozilla/olympia/commit/5693642063d5b9e459c803bd831732dec959dd69
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Target Milestone: --- → 2015-08
Comment 20•9 years ago
|
||
Francesco, I'm sorry to be the bringer of bad news, but I believe the fix in https://github.com/mozilla/olympia/pull/595 is incomplete (see the screenshot attached).
Updated•9 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 21•9 years ago
|
||
(Meaningless drivel, I know, but I am so infuriated, have spent FAR too much time trying to download something...) And until "fixed", could changes be reverted, or made, so at least someone using a non-"Firefox" browser can more easily download?
Comment 22•9 years ago
|
||
Francesco will back on Monday, August 31st, and can do another PR to fix this. Or, if there's another developer available to make the improvements so that non-firefox browsers can still download the XPI files without jumping through hoops.
Assignee | ||
Comment 23•9 years ago
|
||
The updated patch shouldn't be related to the current issue with the button overflow. To my knowledge, the patch submitted to add a download option from non-firefox browsers should be completed. Is there anyway that we can push the "download anyway" patch to prod soon, Mathieu?
Flags: needinfo?(mathieu)
Comment 24•9 years ago
|
||
Francesco I believe there's two issues (sadly) addressed in this thread: 1/ https://bugzilla.mozilla.org/show_bug.cgi?id=1170736#c11: we need a "download anyway" button: according to therube, this isn't working? Could you please give some steps to reproduce the issue you're experiencing? 2/ https://bugzilla.mozilla.org/show_bug.cgi?id=1170736#c7: the install buttons in the collections page need to be correctly wrapped: the latest fix didn't correctly fix this issue for all cases, see the screenshot in https://bugzilla.mozilla.org/show_bug.cgi?id=1170736#c20
Flags: needinfo?(mathieu) → needinfo?(therubex)
Comment 25•9 years ago
|
||
Screenshot.
(I used a "scrolling window" capture utility, so it only approximates what I'm seeing, but the idea is...)
0.5.1, does have a 'Download Anyway' link (even though you can't see it in the shot).
All other versions only show the green (the Hulk) "Only with Firefox..." button (& its link to a page that, well wants to download FF).
> https://www.mozilla.org/firefox/new/?scene=2&utm_source=addons.mozilla.org&utm_medium=referral&utm_campaign=non-fx-button#download-fx
Hardly the type of UX /I/ would expect.
Flags: needinfo?(therubex)
Comment 26•9 years ago
|
||
URL: https://addons.mozilla.org/en-US/firefox/addon/locallink/versions/ Version 0.5.1-signed Says "Only with Firefox..." And it does have a 'Download Anyway' option, & that is fine. That is OK - as far as it goes. "As far as it goes", because the Download Anyway /link/ points to: > .../downloads/file/1439/locallink-0.1-fx.xpi?src=version-history and while the link happens to be valid, it does not point to the expected v0.5.1, instead it points to v0.1. And then none of the other (older) versions have 'Download Anyway' links at all. (This particular extension is not an isolated case, just one I happened to want to get - just now.)
Assignee | ||
Comment 27•9 years ago
|
||
We will be revisiting the entire implementation of this button shortly
Assignee | ||
Updated•9 years ago
|
Summary: AMO Non-Firefox Add-on Download Button → AMO Non-Firefox Add-on Download Button (tracking)
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
Comment 28•8 years ago
|
||
Just to point out, that at present, it seems the ONLY browser that can download from a [FF] /versions/ page, is FF. Others are simply presented with the Green Wall of Death. Oddly on a [SeaMonkey] /versions/ page, other browsers, like Chrome, can download. FF /versions/ page: https://addons.mozilla.org/en-US/firefox/addon/noscript/versions/ SeaMonkey /versions/ page: https://addons.mozilla.org/en-US/seamonkey/addon/noscript/versions/ And a FF extension with no SeaMonkey counterpart: https://addons.mozilla.org/en-US/firefox/addon/noise/versions/ So both SeaMonkey and Chrome, & probably everything else ? - except for FF, are blocked from downloading from that /versions/ page. Yes, you can download from the extensions main page, the 'Download Anyway' link, but that does not help if you need to get a specific version - other then "current". This is the "open Web" that you tout. Yes, open for FF, but closed to all else. Sorry but the current situation is just an abomination.
Comment 29•8 years ago
|
||
Did you revert something?
As it is working today :-).
> https://addons.mozilla.org/en-US/firefox/addon/noise/versions/
Thank you if you did.
(Makes a world of difference when you want to do something, & you don't have to jump through hoops just to get it done.)
Comment 30•8 years ago
|
||
(Still not working in [some ancient version, 38 it seems, of] Chrome that I have on hand. Nonetheless, so long as we're not totally locked out, better.)
Comment 31•8 years ago
|
||
I know I'm talking to myself, & I'm fine with that... I typically know how to work around things, & I know how to do so with AMO, but it seems to me, that on the particular day, 2016-06-09, my typical work-arounds did not work (unless I screwed up in doing so ... ?), so... I'll just note what I'm seeing now... Chrome. Green Wall of Death. (I don't know how to disable JavasScript in Chrome?) non-FF "Mozilla browser", like SeaMonkey. By default, you still get the Green Wall of Death. Disable JavaScript, globally, works. JavaScript, allow mozilla.org, but block mozilla.net, works. I /must/ have tried those work-arounds on 2016-06-09, as that would be the typical & expected thing for me to do (or did I?) but they did not work -at that time (cause if they had worked, I would have had no need to even comment further here in this bug). (Maybe I screwed up at that time? Don't know? Anyhow...)
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 days ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•