1170764 - SIM PIN Dialog: OK and Cancel buttons do nothing

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::System UI, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

STR:

1.) Enable SIM PIN
2.) Reboot phone
3.) When SIM PIN dialog pops up, try to click Cancel or OK

Neither button works.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Can we get a regression window for this?

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

The issue does not occur on v2.2.

Comment 3

[John Thomas [:Johnt]]

Mozilla Inbound Regression Window

First Working
Environmental Variables
Device: Flame 3.0
BuildID: 20150601113741
Gaia: 85e6fcef45c0cb2c017739df42b68b96cf5bb9c3
Gecko: cc758e8f18e3
Version: 41.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

First Broken
Environmental Variables:
Device: Flame 3.0
BuildID: 20150601115340
Gaia: 85e6fcef45c0cb2c017739df42b68b96cf5bb9c3
Gecko: 4cb3a97de6ee
Version: 41.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Last Working gaia / First Broken gecko - This issue occurs with broken Gecko.
Gaia: 85e6fcef45c0cb2c017739df42b68b96cf5bb9c3
Gecko: 4cb3a97de6ee

First Broken gaia / Last Working gecko - This issue does NOT occur with broken Gecko.
Gaia: 85e6fcef45c0cb2c017739df42b68b96cf5bb9c3
Gecko: cc758e8f18e3

Mozilla Inbound Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=cc758e8f18e3&tochange=4cb3a97de6ee

Issue appears to occur due to changes made in Bug 1153589

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Kartikaya, here is another bug that appears to be caused by the landing for bug 1153589.

Comment 5

[Gregor Wagner [:gwagner]]

Bug 1153589 got backed out.

Comment 6

[Timothy Nikkel (:tnikkel)]

(In reply to Michael Henretty [:mhenretty] from comment #0)
> 1.) Enable SIM PIN

Is there some way to test this without a SIM?

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Unfortunately, not without hacking the code :/

Comment 8

[Timothy Nikkel (:tnikkel)]

I'm all about hacking the code. Do you have a patch or pointer to the code that needs changing?

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

You'll need a way to call the SimLockSystemDialog.show method [1]. You'll probably have to do something like the following from the context of the system app:

`window.core.mobileConnectionCore.simLockManager.simLockSystemDialog.show()`

This will probably throw an error, but you should be able to see and test the Skip and Cancel buttons. If it works we are fine, if it doesn't work we'll need somebody with a SIM to actually verify.

1.) https://github.com/mozilla-b2g/gaia/blob/558d47a1d95f28ff9fbc2ccc12afaece067ea626/apps/system/js/sim_lock_system_dialog.js#L433

Comment 10

[Timothy Nikkel (:tnikkel)]

Turns out that an old expired sim lets me do enough to recreate this bug.

Comment 11

[Duane Dixon [:ddixon]]

This issue is verified fixed on the latest Aries 2.5, Flame 2.5 (nightly) build. The "Skip" and "Ok" buttons are functional and handle user input correctly.  The user can assign a SIM pin, reboot/power cycle the device, then successfully get passed the SIM pin dialogue box using the aforementioned buttons. 

Device: Aries 2.5 (Master)
Build ID: 20150812231434
Gaia: 52f3ea58df38e5427f6afeb636bc6ad01d24022f
Gecko: 7649ffe28b67aa2dad0f67ea01500c0ff91b2bac
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (Master)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Environmental Variables:
Device: Flame 2.5 (Master)
Build ID: 20150901030202
Gaia: c80e8ff25425b007181fd6e3de0500a0358fab37
Gecko: cafb1c90f794a73100a8f0afb9fe3301df0f2bde
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (Master)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0