1170797 - release upload screen "hangs" if no file provided

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)

Description

[hwine]

The button to select a file is overwritten by the "activity indicator", no cancel button.

STR:
 - open dialog box to upload a release
 - fill in all mandatory fields, but do not specify a file
 - choose "ok"

What happens:
 - report of error "no release provided" (or some such)
 - no way to enter/update that info
 - no way to cancel the dialog box (except by using menu to go to another page)

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/ac4d60f726fd5faba9291e1b5ddf0627b4b0dfaf
bug 1170797: "unhang" release upload screen if no file provided (#163). r=bhearsum

Comment 2

[[e-mail] (:bhearsum)]

This doesn't seem to be working in stage - I get the modal pop-up that says "No file has been selected", but the buttons do not re-appear - the moving dots in the bottom right just continue endlessly. Maybe this had some bad interaction with https://bugzilla.mozilla.org/show_bug.cgi?id=1301066?

Comment 3

[Njira]

Hi Ben. I am looking into it.

(In reply to Ben Hearsum (:bhearsum) from comment #2)
> This doesn't seem to be working in stage - I get the modal pop-up that says
> "No file has been selected", but the buttons do not re-appear - the moving
> dots in the bottom right just continue endlessly. Maybe this had some bad
> interaction with https://bugzilla.mozilla.org/show_bug.cgi?id=1301066?

Comment 4

[[e-mail] (:bhearsum)]

(In reply to Njira from comment #3)
> Hi Ben. I am looking into it.
> 
> (In reply to Ben Hearsum (:bhearsum) from comment #2)
> > This doesn't seem to be working in stage - I get the modal pop-up that says
> > "No file has been selected", but the buttons do not re-appear - the moving
> > dots in the bottom right just continue endlessly. Maybe this had some bad
> > interaction with https://bugzilla.mozilla.org/show_bug.cgi?id=1301066?

Hm, I'm unable to reproduce this now, too...I wonder if https://github.com/mozilla/balrog/commit/5a76e64fdf03c87aedb4dc9a9dcf47faf64b8d65 fixed it?

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum (:bhearsum) from comment #4)
> (In reply to Njira from comment #3)
> > Hi Ben. I am looking into it.
> > 
> > (In reply to Ben Hearsum (:bhearsum) from comment #2)
> > > This doesn't seem to be working in stage - I get the modal pop-up that says
> > > "No file has been selected", but the buttons do not re-appear - the moving
> > > dots in the bottom right just continue endlessly. Maybe this had some bad
> > > interaction with https://bugzilla.mozilla.org/show_bug.cgi?id=1301066?
> 
> Hm, I'm unable to reproduce this now, too...I wonder if
> https://github.com/mozilla/balrog/commit/
> 5a76e64fdf03c87aedb4dc9a9dcf47faf64b8d65 fixed it?

I'm pretty sure it did actually, after rereading this bug and the code again. Let's call this fixed :)

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/0d2341b0ce9de6c58ee6ce5cd79944105c8dd4e5
bug 1170797: "unhang" release upload screen if no file provided (#186). r=bhearsum