1170803 - Preferences says that Firefox is not the default browser on Windows 10 when the Default Applications has Firefox set as the default browser

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

The preferences code checks for all filetype associations, whereas in newer versions of Windows the default browser association is set through the Settings application which just has one generic "Web browser" setting.

The attached patch matches the behavior of the "default browser" status in the preferences to the same behavior as seen when starting up the browser.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2

Depends on the patch in bug 1167294.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9daecda7080d

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9daecda7080d

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8614375 [details] [diff] [review]
Patch v2

Approval Request Comment
[Feature/regressing bug #]: windows 10 default browser (bug 1167294)
[User impact if declined]: confusing text within the preferences related to what app is the default browser
[Describe test coverage new/current, TreeHerder]: manual testing
[Risks and why]: relies on the system default browser setting to report if the browser is the default browser instead of checking for all associated filetypes (only changed behaviors on windows 8+)
[String/UUID change made/needed]: none

See follow-up for changing this to only adjust behavior on windows 10+ (bug 1173357)

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8614375 [details] [diff] [review]
Patch v2

Approval Request Comment
[Feature/regressing bug #]: windows 10 default browser (bug 1167294)
[User impact if declined]: confusing text within the preferences related to what app is the default browser
[Describe test coverage new/current, TreeHerder]: manual testing
[Risks and why]: relies on the system default browser setting to report if the browser is the default browser instead of checking for all associated filetypes (only changed behaviors on windows 8+)
[String/UUID change made/needed]: none

(this is part of a approval-mozilla-beta request in conjunction with bug 1170803 and bug 1173357)

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8614375 [details] [diff] [review]
Patch v2

We want a great support of Windows 10 in 40. However, I am not sure we should take it in beta. Liz will make the call.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8614375 [details] [diff] [review]
Patch v2

Yes, we want this on beta along with the other default browser for win 10 patches - so as not to lose Firefox users when they upgrade.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/057ae6427e22

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for Beta uplift.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Nevermind, bugs got out of order in my queue.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b6a371e7e153