1170819 - Enable payments in Fennec release channel

Status: VERIFIED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect, P1)

Description

[Andy McKay]

It seems like when the payments settings got added to fennec, they got turned off in production and never turned on.

https://dxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#775-781

If I understand the #ifndef RELEASE_BUILD, that means payments are not enabled in stable but just Nightly and Aurora. Can we please get that turned on as soon as possible since we launched payments for Android for the Marketplace a while ago.

If there's a . release of 38, this should be a relatively minor bug to fix in that release I imagine.

Comment 1

[Andy McKay]

[Tracking Requested - why for this release]: would like to get that ifndef removed asap and should be a low impact change

Comment 2

[Andy McKay]

Here's the mercurial branch and it points to:

https://hg.mozilla.org/mozilla-central/annotate/9eae3880b132/mobile/android/app/mobile.js#l775

And this commit:

https://hg.mozilla.org/mozilla-central/diff/6786a2fc7351/mobile/android/app/mobile.js

Now I'm confused.

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

There were two ifdefs in a row. Looks like the version control did not do a good job of dealing with code deletion. https://hg.mozilla.org/mozilla-central/rev/4a854c013d42 is what you want. Which shows bug 878327 introduced the ifdef. Bug 898499 introduced "dom.mozPay.enabled", true.

Has this been tested and shown to work on Firefox for Android Aurora or Nightly? We generally don't turn on major features in point releases.

Comment 4

[Andy McKay]

Yes the QA team has been testing using nightly, beta for the last few months and signed it off once the WebIDL changes were completed earlier this year. We've been waiting for 38 to turn it on and had no idea the prefs were marked off like that.

The only impact is access to the marketplace web based payments flow.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

I'm OK with flipping it on as long as Andy/QA feel this has been tested on Fennec Nightly and Aurora.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

[Tracking Requested - why for this release]:
This will have to be fixed for 39 and wait for this release to go live.

Sorry, we cannot take changes like that in release. For now, there is no driver for a 38.0.6 of Fennec (and we probably won't have one as 38.0.5 is just 38+adjust SDK+a few low risk fixes).

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Please let me know when you land a fix for this, and request uplift to aurora and beta. Thanks!

Comment 8

[Richard Newman [:rnewman]]

Attachment: Enable payments in Fennec release channel. v1

Rubberstamp from Andy that these prefs are correct.

Rubberstamp from mfinkle for the sake of process.

Comment 9

[jen strickland :jenstrickland]

Tracked for 39.

Comment 10

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/f078082c2f34

Comment 11

[Richard Newman [:rnewman]]

Over to you to request uplifts, Andy.

Comment 12

[Kevin Brosnan [Ex-Mozilla]]

Comment on attachment 8615019 [details] [diff] [review]
Enable payments in Fennec release channel. v1

You'll need to set the approval-mozilla-beta, approval-mozilla-aurora to ? at https://bugzilla.mozilla.org/attachment.cgi?id=8615019&action=edit

Comment 13

[Andy McKay]

Comment on attachment 8615019 [details] [diff] [review]
Enable payments in Fennec release channel. v1

Approval Request Comment
[Feature/regressing bug #]: Marketplace payments
[User impact if declined]: Marketplace payments will not be active
[Describe test coverage new/current, TreeHerder]: Web QA have been testing on nightly
[Risks and why]: No risk, this feature has been well testeed
[String/UUID change made/needed]: None

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f078082c2f34

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f078082c2f34

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

So, was this on in aurora for 39?

Comment 17

[Richard Newman [:rnewman]]

It was guarded by a release channel flag, so it was on for Nightly 39 and Aurora 39, but off for Beta 39 and release 39.

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

The things giving me pause here are:  new feature enabling on beta; no one even noticed this was broken till beta 2; are you now sure that this isn't going to be messed up again when we move to release?  I don't want to end up doing a point release for this. 

Since this was tested and on for 39 during nightly and aurora, that addresses my first concern, so I'm ok uplifting this and making sure the feature carries on for beta. Are you continuing testing during beta?

Comment 19

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8615019 [details] [diff] [review]
Enable payments in Fennec release channel. v1

Approved for uplift to aurora and beta. This feature was preffed on for 39 nightly and aurora; this was an oversight in the ifdef statements accidentally turning off the feature when we moved to beta.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2b9ab3af292d

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a2c9c4c49319

Comment 22

[Andy McKay]

I just tested Beta, noted the prefs are installed and got through to the payments page for the marketplace just fine. I believe that what's on Beta is whats going out on release, so things look good. Thanks.