1170915 - Tab thumbnail code doesn't account for Reader toolbar

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Wesley Johnston (:wesj)]

STR:
1.) Open a page in reading mode
2.) Touch the tabs button to open the tray
3.) Touch the tab to switch back to it

Results:
The web page zooms into view, then janks as it moves down to account for the reader toolbar. Zooming it to fullscreen should probably account for the toolbar and place the webview/screenshot below it.

Comment 1

[allenngn]

Attachment: Bug 1170915 - Tab thumbnail code doesn't account for reader toolbar

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I find it hard to see a difference between with and without this patch. Handing over to sleroux and darrin for some additional feedback.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8631772 [details] [review]
Bug 1170915 - Tab thumbnail code doesn't account for reader toolbar

Adding sleroux and darrin for additional feedback. I would not mind moving this to v1.1 if there is a risk of regressions.

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8631772 [details] [review]
Bug 1170915 - Tab thumbnail code doesn't account for reader toolbar

Hey Allen,

Thanks for the patch! I ran it on the iOS simulator and I'm still seeing the reader mode bar appear/disappear behind the screenshot turning the transition. I think what we need to do is animate the actual reader mode bar during the transition instead of including it into the screenshot.

The BrowserViewController implements methods from the Transitionable protocol which get called during the different stages during the transition animation. This is where we do things like move/alpha the url bar and toolbars. What I propose we try doing is add the reader mode bar transition as part of this. The URL bar scales down along with the web page and moves down so it hides behind the tab. For the reader bar, I can see us doing something similar where it scales down and 'collapses' upwards during the browser -> tab tray animation. When the tab animates to the browser, the reader mode bar could 'expand' downwards below the url bar while the url bar expands upwards. 

Darrin, what are your thoughts on this kind of animation?

Comment 5

[Stephan Leroux [:sleroux]]

Will be resolved as part of the refactor involved with https://bugzilla.mozilla.org/show_bug.cgi?id=1184233

Comment 6

[Stephan Leroux [:sleroux]]

Resolved as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1184233