Closed
Bug 1170926
Opened 9 years ago
Closed 9 years ago
Sync button in hamburger menu doesn't update when user needs to re-enter their password.
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: markh, Assigned: markh)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.12 KB,
patch
|
adw
:
review+
Sylvestre
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Bug 1131413 changed the notification sent by Sync when the user needs to reauthenticate - however, browser-fxaccounts didn't have the corresponding change for the new notification and therefore doesn't update when in a "reconnect" state. The following patch adds a the new notification - it keeps the "old" one as it may still be sent in some cases. There's no test because we don't have a good test story for Sync, so the best the test could currently do is hard-code the notification being sent and check the UI updates - but that wouldn't have picked up this regression as the notification being sent changed - IOW, to effectively test this we really need to have Sync itself be in that state rather than simulating that state.
Attachment #8614529 -
Flags: review?(adw)
Updated•9 years ago
|
Attachment #8614529 -
Flags: review?(adw) → review+
Comment 2•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f2dad87192c8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8614529 [details] [diff] [review] 0003-Bug-XXXXXXX-have-the-hamburger-menu-notice-the-needs.patch Approval Request Comment [Feature/regressing bug #]: reading list regression [User impact if declined]: The hamburger menu will not update to reflect the user needs to re-enter their Sync password. [Describe test coverage new/current, TreeHerder]: New test [Risks and why]: Very low, limited to the Sync UI [String/UUID change made/needed]: None
Attachment #8614529 -
Flags: approval-mozilla-beta?
Attachment #8614529 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Keywords: regression
Comment 4•9 years ago
|
||
Mark can you describe how we can manually reproduce and verify this? Is there anyone who is focusing on Sync/Accounts QA?
Flags: needinfo?(markh)
Comment 5•9 years ago
|
||
Comment on attachment 8614529 [details] [diff] [review] 0003-Bug-XXXXXXX-have-the-hamburger-menu-notice-the-needs.patch Taking it to aurora to increase the coverage
Attachment #8614529 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Liz Henry (:lizzard) from comment #4) > Mark can you describe how we can manually reproduce and verify this? Change psync assword, then wait a few hours until Prefs->Sync says "please reconnect" Without this patch: hamburger menu doesn't reflect the "please reconnect" state. With it, it correctly does. > Is there anyone who is focusing on Sync/Accounts QA? Not that I'm aware of :(
Flags: needinfo?(markh)
Comment 8•9 years ago
|
||
Comment on attachment 8614529 [details] [diff] [review] 0003-Bug-XXXXXXX-have-the-hamburger-menu-notice-the-needs.patch OK, let's try this on beta. Good to verify it and we'll ask QE if they can do another round of functional testing for sync this week.
Attachment #8614529 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•9 years ago
|
Flags: qe-verify+
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
Updated•5 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•