1170941 - [v2.2][Gaia::UI Tests]test_sms_with_picture_attached.py: "TimeoutException: TimeoutException: Timed out after 301.6 seconds"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Lance（leave from Mozilla）]

[Description]
test_sms_with_picture_attached.py fails

[Steps to Reproduce]
Run the test_sms_with_picture_attached.py

[Reproduction Frequency]
Always, 5/5

[Reproducible manually]
NO

Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/B2G.v2.2.pvt.flame.gaiatest.smoketest/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client_mozilla_b2g37_v2_2-0.1-py2.7.egg/marionette/marionette_test.py", line 268, in run
    testMethod()
  File "/var/lib/jenkins/workspace/B2G.v2.2.pvt.flame.gaiatest.smoketest/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_with_picture_attached.py", line 69, in test_sms_cropped_picture
    self.message_thread.wait_for_received_messages(timeout=300)
  File "/var/lib/jenkins/workspace/B2G.v2.2.pvt.flame.gaiatest.smoketest/tests/python/gaia-ui-tests/gaiatest/apps/messages/regions/message_thread.py", line 27, in wait_for_received_messages
    *self._received_message_content_locator))))
  File "/var/lib/jenkins/workspace/B2G.v2.2.pvt.flame.gaiatest.smoketest/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client_mozilla_b2g37_v2_2-0.1-py2.7.egg/marionette/wait.py", line 143, in until
    cause=last_exc)
TimeoutException: TimeoutException: Timed out after 301.6 seconds

[Build info]
Device firmware (base) 	L1TC100118D0
Device firmware (date) 	02 Jun 2015 15:42:50
Device firmware (incremental) 	eng.cltbld.20150602.034241
Device firmware (release) 	4.4.2
Device identifier 	flame
Gaia date 	01 Jun 2015 21:53:00
Gaia revision 	a675e5472944
Gecko build 	20150602002504
Gecko revision 	c163c2a5b921
Gecko version 	37.0

[Attachments]
http://mozilla-twqa.github.io/Gaiatest-Reports/2015/06/20150602002504-v2.2-flame/smoketest.html

Comment 1

[Martijn Wargers (dead)]

This test was just fixed in bug 1166330, but this appears to be a problem with receiving an sms message after having sent one.
The screenshot makes it also look like nothing has been received. So I guess this was a Plivo malfunction?

Comment 2

[Cynthia Tang [:cynthiatang]]

Hi Martijn,
The result is passed if I keep attachment_options.tap_cancel() in test_sms_with_picture_attached.py.

Comment 3

[Martijn Wargers (dead)]

(In reply to Cynthia Tang [:cynthiatang] from comment #2)
> Hi Martijn,
> The result is passed if I keep attachment_options.tap_cancel() in
> test_sms_with_picture_attached.py.

Cynthia, what are you asking me? You want to add attachment_options.tap_cancel() to the test? Why would that pass the test and why would that be a good idea? The SMS would then not be sent, no?
So this test is still passing on master?
I wonder if there is a relation with bug 1169680 here.

Comment 4

[Cynthia Tang [:cynthiatang]]

Attachment: [2.2] After tapping back button

Hi Martijn,
I think the behavior is different. 

The SMS would be sent. This test with tapping?
 >> Yes, the SMS would be sent.
So this test is still passing on master?
 >> No. Your patch is fine for master.   

1) Launch Messages app
2) Compose new message and tap paperclip to attach image from gallery
3) Crop image on image crop screen and press done
4) Tap attached image and select view 
5) Tap back button

After tapping back button, you can see that 
* Flame 2.2: User have to tap back button. Please refer the attachment[2.2] After tapping back button
* Flame Master: User don't need a cancel button. Please refer the attachment [Master] After tapping back button

Comment 5

[Cynthia Tang [:cynthiatang]]

Attachment: [Master] After tapping back button

Comment 6

[Cynthia Tang [:cynthiatang]]

Hi Jenny,
Could you please help us to clarify the user story for SMS on v2.2? Thank you.

Comment 7

[Martijn Wargers (dead)]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #3)
> (In reply to Cynthia Tang [:cynthiatang] from comment #2)
> > Hi Martijn,
> > The result is passed if I keep attachment_options.tap_cancel() in
> > test_sms_with_picture_attached.py.
> 
> Cynthia, what are you asking me? You want to add
> attachment_options.tap_cancel() to the test? Why would that pass the test
> and why would that be a good idea? The SMS would then not be sent, no?
> So this test is still passing on master?
> I wonder if there is a relation with bug 1169680 here.

Ah, never mind. You asked me to merge the v2.2 pull request for 
bug 1166330 , but that one included the deletion of attachment_options.tap_cancel(). You also have a pull request in bug 1166632. That didn't include the deletion of attachment_options.tap_cancel(). That one should have been merged.
In any case, you can easily fix this by re-adding attachment_options.tap_cancel() to the test.

Comment 8

[Jenny Lee]

(In reply to Cynthia Tang [:cynthiatang] from comment #6)
> Hi Jenny,
> Could you please help us to clarify the user story for SMS on v2.2? Thank
> you.

Hi Cynthia,

The behavior on master is correct. The reason is that SMS developer has made some code structure changes, so tapping on "back" will close the menu altogether, thanks!

Comment 9

[Cynthia Tang [:cynthiatang]]

Attachment: [gaia] cynthiatang:bug1170941 > mozilla-b2g:v2.2

Hi Martijn,
Could you please review it again? Thank you.

Hi Jenny,
Thanks for your explain.

Comment 10

[Cynthia Tang [:cynthiatang]]

Attachment: [gaia] cynthiatang:bug1170941_2 > mozilla-b2g:v2.2

Hi Martijn,
Could you please review and merge it? Thank you.

Running tests
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=2ab397fa067b12f37f8bb5ab580ece4528b7604f

Comment 11

[Cynthia Tang [:cynthiatang]]

Hi Martijn,
I re-trigger gaia-try. Thanks.

Running tests
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=20f63f4bd2c0d86a592676b78879805f4098d2af

Comment 12

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/1a4a3fd78e4cd628652685c4f56551ee307506b1