1170967 - [Homescreen] If user launches a smart collection with multiple clicks, it will load with error and icons on top can be moved to bottom.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Verson Xiong (Leave from Mozilla)]

Attachment: logcat_2211.txt

[1.Description]:
[Flame v2.2 & v3.0][Nexus5 v2.2 & v3.0][Homescreen]If user taps a smart collection for multiple times to open it, then add a bookmark to top position, and then move it to the bottom. After confirming this change, user can't open this smart collection again.
Found time:22:11
See attchment:logcat_22:11.txt & video_2211.mp4

[2.Testing Steps]: 
1.Click a smart collection 2-3 times.
2.Add a bookmark to top position.
3.Move it to bottom.
4.Tap home button.
5.Try to open the smart collection that you opened in step 1.

[3.Expected Result]: 
5.User can open smart collection again.

[4.Actual Result]: 
5.Smart collection is always in loading status.

[5.Reproduction build]: 
Device: Flame 2.2 version(Affected):
Build ID               20150602162502
Gaia Revision          a9aeb08263f1a727136e8ae78425e52431c82770
Gaia Date              2015-06-02 13:04:40
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5b3f1796ddf6
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150602.195401
Firmware Date          Tue Jun  2 19:54:11 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 version(Affected):
Build ID               20150602160205
Gaia Revision          6d477a7884273886605049b20f60af5c1583a150
Gaia Date              2015-06-01 16:41:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9eae3880b132
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150602.192511
Firmware Date          Tue Jun  2 19:25:20 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5_2.2 version(Affected):
Build ID               20150602162502
Gaia Revision          a9aeb08263f1a727136e8ae78425e52431c82770
Gaia Date              2015-06-02 13:04:40
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5b3f1796ddf6
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150602.193831
Firmware Date          Tue Jun  2 19:38:46 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5_3.0 version(Affected):
Build ID               20150602160205
Gaia Revision          6d477a7884273886605049b20f60af5c1583a150
Gaia Date              2015-06-01 16:41:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9eae3880b132
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150602.192258
Firmware Date          Tue Jun  2 19:23:13 EDT 2015
Bootloader             HHZ12f

[6.Reproduction Frequency]: 
Always Recurrence,3/5

[7.TCID]: 
Free Test

[8.Note]:
If user taps smart collections one by one,bookmark will mixed in one smart collection.

Comment 1

[Verson Xiong (Leave from Mozilla)]

Attachment: video_2211.mp4

Comment 2

[Gregor Wagner [:gwagner]]

Can we check if this is a regression on 2.2 by testing a build from a few months ago?

Comment 3

[Hermes Cheng (inactive after July 27, 2015)]

Actually, I cannot move any icon from top of collection to below section (step 3 of STR at comment 0).

Comment 4

[Hermes Cheng (inactive after July 27, 2015)]

My test environments are as below

*v2.2 (nexus 5)
Build ID               20150603162502

*v2.2 (flame)
Build ID               20150603162502

*master (flame)
Build ID               20150603160203

Comment 5

[Gregor Wagner [:gwagner]]

(In reply to Hermes Cheng[:hermescheng] from comment #3)
> Actually, I cannot move any icon from top of collection to below section
> (step 3 of STR at comment 0).

This might be fixed by the backout of 1166347.

Comment 6

[Hermes Cheng (inactive after July 27, 2015)]

I tried a build before backout of 1166347, but still got similar result (comment 4).

I think this is correct behavior which user cannot move any installed app listed on top of collection to below suggested list.

@Verson, could you tell me the build id and version in your video? I also noticed that the layout has a little different with mine. In your video, there is one additional line at the bottom.

Comment 7

[Verson Xiong (Leave from Mozilla)]

(In reply to Hermes Cheng[:hermescheng] from comment #6)
> I tried a build before backout of 1166347, but still got similar result
> (comment 4).
> 
> I think this is correct behavior which user cannot move any installed app
> listed on top of collection to below suggested list.
> 
> @Verson, could you tell me the build id and version in your video? I also
> noticed that the layout has a little different with mine. In your video,
> there is one additional line at the bottom.

Hi Hermes,

My build is PVT nightly build ,and I can reproduce this bug on lastest build of Flame 2.2,master & Nexus5 2.2,master.
If user taps a smart collection once to open it, the layout looks normal, and user can't move an icon at top to bottom location. 
If user tries "multiple taps" on a smart collection to open it, the smart collection page will load with error, and user can find a line at bottom of page.  user can move an icon at top to bottom location.

I've updated the video and now it contains both the normal and unnormal behaviour.
See attachment compare.MP4

Build id and version in new video

Flame2.2:
Build ID               20150603162502
Gaia Revision          b92e782ca12397acc3eb52f2e237522c0213f4e0
Gaia Date              2015-06-03 21:02:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/74421c778aff
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150603.195036
Firmware Date          Wed Jun  3 19:50:46 EDT 2015
Bootloader             L1TC000118D0

Comment 8

[Verson Xiong (Leave from Mozilla)]

Attachment: compare.mp4

Comment 9

[Hermes Cheng (inactive after July 27, 2015)]

Verson, thanks! I misunderstood the issue. Update the summary for it.

When launching a smart collection with multiple tapping, adb logcat will get below errors several times. I guess there are several requests which result in race condition.

* Errors in logcat: (from [1])
I/Smart Collections( 6258): Content JS LOG: Error, duplicate identifier:  http://m.collegehumor.com/ GridView.prototype.add@app://collection.gaiamobile.org/gaia_build_defer_view.js:416:113
I/Smart Collections( 6258): proto.add@app://collection.gaiamobile.org/gaia_build_defer_view.js:468:775
I/Smart Collections( 6258): render@app://collection.gaiamobile.org/gaia_build_defer_view.js:919:43
I/Smart Collections( 6258): addToGrid@app://collection.gaiamobile.org/gaia_build_defer_view.js:918:1
I/Smart Collections( 6258): render@app://collection.gaiamobile.org/gaia_build_defer_view.js:921:34
I/Smart Collections( 6258): success@app://collection.gaiamobile.org/gaia_build_defer_view.js:968:178
I/Smart Collections( 6258): Promise*makeRequest@app://collection.gaiamobile.org/gaia_build_defer_view.js:968:34
I/Smart Collections( 6258): queueRequest@app://collection.gaiamobile.org/gaia_build_defer_view.js:965:46
I/Smart Collections( 6258): ViewApps/<@app://collection.gaiamobile.org/gaia_build_defer_view.js:963:198
I/Smart Collections( 6258): Promise*ViewApps@app://collection.gaiamobile.org/gaia_build_defer_view.js:963:48
I/Smart Collections( 6258): HandleView@app://collection.gaiamobile.org/gaia_build_defer_view.js:958:413
I/Smart Collections( 6258): onActivity@app://collection.gaiamobile.org/gaia_build_defer_view.js:959:166


Kevin, could you help here?

[1] https://github.com/mozilla-b2g/gaia/blob/master/shared/elements/gaia_grid/js/grid_view.js#L96

Comment 10

[Verson Xiong (Leave from Mozilla)]

(In reply to Gregor Wagner [:gwagner] from comment #2)
> Can we check if this is a regression on 2.2 by testing a build from a few
> months ago?

Hi Gregor,
I check the build from a few months ago.

The issue can't be reproduce on Flame 2.2 build of six mouth ago.

Device:Flame 2.2(unaffected)
Build ID               20141211173954
Gaia Revision          1d9ae9cca415ad093beba9521c429350e1f2b14d
Gaia Date              2014-12-11 21:33:40
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/5288b15d22de
Gecko Version          37.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150112.214430
Firmware Date          Mon Jan 12 21:44:41 EST 2015
Bootloader             L1TC000118D0

Comment 11

[Pi Wei Cheng [:piwei] (inactive)]

I have not personally checked this issue but according to comment 10 this is a regression within the master branch (comment 10 used a build from when 2.2 was master).

Comment 12

[Kevin Grandon :kgrandon]

I'm on PTO, but could look when back. Not sure if it's a blocker, I think we were possibly considering removing collection code at one point.

Comment 13

[Verson Xiong (Leave from Mozilla)]

Design is changed on latest Aries KK 2.5/v2.6 and Flame KK v2.5/v2.6 build,we can't use smart collection anymore.
Actual results: smartcollection function is removed.
Reproduce rate: 0/10

Device: Aries KK v2.6 master( Unffected )
Build ID               20151112014800
Gaia Revision          fdb66f75963fa9255f707af87f405d54892e5e7d
Gaia Date              2015-11-11 17:17:32
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/a8ed7dd831d1969a5a1a8636e63bd93d6aeaf94a
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151112.011957
Firmware Date          Thu Nov 12 01:20:05 UTC 2015
Bootloader             s1

Device: Aries KK v2.5( Unffected )
Build ID               20151110094357
Gaia Revision          07baf613699fa6225359c7f04825c5caeb71d424
Gaia Date              2015-11-09 21:32:50
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e14287b00a514a15418dfaa89287030c588ad19d
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151110.090331
Firmware Date          Tue Nov 10 09:03:39 UTC 2015
Bootloader             s1

Device: Flame KK v2.6 master 512mb( Unffected )
Build ID               20151111150236
Gaia Revision          22f8023b112dfae83531b0a075ab9eb9a5444dfa
Gaia Date              2015-11-10 23:35:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/84a7cf29f4f14c9b359db2f7f19c0abd6a8e178e
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151111.182640
Firmware Date          Wed Nov 11 18:26:52 EST 2015
Bootloader             L1TC000118D0

Device: Flame KK v2.5  512mb( Unffected )
Build ID               20151109004552
Gaia Revision          cf646c52bb947af28329b0a100df91d1b1f2a907
Gaia Date              2015-11-09 02:55:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4eafef5b80f8985c94c4a067f130d37513e1a581
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.041411
Firmware Date          Mon Nov  9 04:14:26 EST 2015
Bootloader             L1TC000118D0