1170971 - Fix BluetoothGattReadParam and BluetoothGattAdvData unpacking in daemon backend

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Jocelyn Liu [:jocelyn] [:joliu]]

We need to fix BluetoothGattReadParam unpack function to follow the structure defined in https://git.kernel.org/cgit/bluetooth/bluez.git/tree/android/hal-msg.h#n1811.

Comment 1

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Bug 1170971: Fix BluetoothGattReadParam unpacking in daemon backend.

Comment 2

[Jocelyn Liu [:jocelyn] [:joliu]]

Revise the bug title to cover a similar unpacking bug.

Comment 3

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Bug 1170971(v2): Fix BluetoothGattReadParam and BluetoothGattAdvData unpacking in daemon backend.

diff:
- fix GattAdvData unpacking

Comment 4

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8614800 [details] [diff] [review]
Bug 1170971(v2): Fix BluetoothGattReadParam and BluetoothGattAdvData unpacking in daemon backend.

Hi Thomas,

I would like to fix another similar unpacking bit together in this bug.
May I have your help to review my patch again?

Thanks,
Jocelyn

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8614800 [details] [diff] [review]
Bug 1170971(v2): Fix BluetoothGattReadParam and BluetoothGattAdvData unpacking in daemon backend.

Review of attachment 8614800 [details] [diff] [review]:
-----------------------------------------------------------------

I would be preferred this being two separate patches.

::: dom/bluetooth/bluedroid/BluetoothDaemonGattInterface.cpp
@@ +1071,5 @@
>        return rv;
>      }
>      /* Read Adv Data */
> +    rv = UnpackPDU(pdu, UnpackArray<uint8_t>(aArg3.mAdvData,
> +                                             static_cast<size_t>(length)));

This cast to 'size_t' shouldn't be required.

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Maybe just put any required change into this bug and we land it all at once.

Comment 7

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: [Final] Bug 1170971 - Patch1: Fix BluetoothGattReadParam unpacking in daemon backend. r=tzimmermann

Comment 8

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: [Final] Bug 1170971 - Patch2: Fix BluetoothGattAdvData unpacking in daemon backend. r=tzimmermann

- address review comments

Thanks for your time, Thomas.

Comment 9

[Jocelyn Liu [:jocelyn] [:joliu]]

try looks good, https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c9cb4d20228

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/dbd50258c090
https://hg.mozilla.org/integration/b2g-inbound/rev/ea5ab01d081b

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dbd50258c090
https://hg.mozilla.org/mozilla-central/rev/ea5ab01d081b