Closed Bug 1170971 Opened 5 years ago Closed 5 years ago

Fix BluetoothGattReadParam and BluetoothGattAdvData unpacking in daemon backend

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
2.2 S14 (12june)
Tracking Status
firefox41 --- fixed

People

(Reporter: yrliou, Assigned: yrliou)

Details

Attachments

(2 files, 2 obsolete files)

We need to fix BluetoothGattReadParam unpack function to follow the structure defined in https://git.kernel.org/cgit/bluetooth/bluez.git/tree/android/hal-msg.h#n1811.
Attachment #8614618 - Flags: review?(tzimmermann) → review+
Revise the bug title to cover a similar unpacking bug.
Summary: Fix BluetoothGattReadParam unpacking in daemon backend → Fix BluetoothGattReadParam and BluetoothGattAdvData unpacking in daemon backend
diff:
- fix GattAdvData unpacking
Attachment #8614618 - Attachment is obsolete: true
Comment on attachment 8614800 [details] [diff] [review]
Bug 1170971(v2): Fix BluetoothGattReadParam and BluetoothGattAdvData unpacking in daemon backend.

Hi Thomas,

I would like to fix another similar unpacking bit together in this bug.
May I have your help to review my patch again?

Thanks,
Jocelyn
Attachment #8614800 - Flags: review?(tzimmermann)
Comment on attachment 8614800 [details] [diff] [review]
Bug 1170971(v2): Fix BluetoothGattReadParam and BluetoothGattAdvData unpacking in daemon backend.

Review of attachment 8614800 [details] [diff] [review]:
-----------------------------------------------------------------

I would be preferred this being two separate patches.

::: dom/bluetooth/bluedroid/BluetoothDaemonGattInterface.cpp
@@ +1071,5 @@
>        return rv;
>      }
>      /* Read Adv Data */
> +    rv = UnpackPDU(pdu, UnpackArray<uint8_t>(aArg3.mAdvData,
> +                                             static_cast<size_t>(length)));

This cast to 'size_t' shouldn't be required.
Attachment #8614800 - Flags: review?(tzimmermann) → review+
Maybe just put any required change into this bug and we land it all at once.
You need to log in before you can comment on or make changes to this bug.