gfx/layers/apz/test/test_wheel_scroll.html fails when using GDK_SCROLL_SMOOTH

RESOLVED FIXED in Firefox 41

Status

()

Core
Widget: Gtk
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: acomminos, Assigned: acomminos)

Tracking

unspecified
mozilla41
Unspecified
Linux
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Our workaround for omitting duplicate GDK_SCROLL_SMOOTH events causes synthesized scroll events to be skipped when GDK_SCROLL_SMOOTH is used for scroll synthesis, making gfx/layers/apz/test/test_wheel_scroll.html fail on the tryserver. This is because synthesized events are all initialized to GDK_CURRENT_TIME.

> #if GTK_CHECK_VERSION(3,4,0)
>     // check for duplicate legacy scroll event, see GNOME bug 726878
>     if (mLastScrollEventTime == aEvent->time)
>         return;                
> #endif
(Assignee)

Comment 1

3 years ago
Created attachment 8614688 [details] [diff] [review]
Only omit legacy scroll events on GTK3.

This patch modifies our detection of duplicate scroll events as documented in bug 958868 to only omit legacy events.

Thanks!
Attachment #8614688 - Flags: review?(karlt)
Attachment #8614688 - Flags: review?(karlt) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/86e252f5ad3e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.