Closed Bug 1171072 Opened 4 years ago Closed 4 years ago

Make libcubeb build for iOS

Categories

(Core :: Audio/Video, defect)

Unspecified
iOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: ted, Assigned: ted)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I got it to build with a lot of hacking, but I would bet it doesn't actually work, I left a lot of TODOs in there. I think I exhausted my abilities in this space, I could use some help.
Also, I'm not totally clear, but maybe these changes need to go upstream first?
https://github.com/kinetiknz/cubeb
bug 1171072 - make libcubeb build on iOS. r?kinetik
Attachment #8614805 - Flags: review?(kinetik)
This patch is kind of a mess, but it builds, so that's something.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> Also, I'm not totally clear, but maybe these changes need to go upstream
> first?
> https://github.com/kinetiknz/cubeb

Ideally, yes... especially if you're volunteering for the pain of updating the configure-y stuff for the iOS build. :-)
Attachment #8614805 - Flags: review?(kinetik) → review+
Comment on attachment 8614805 [details]
MozReview Request: bug 1171072 - make libcubeb build on iOS. r?kinetik

https://reviewboard.mozilla.org/r/10063/#review8887

Thanks for doing this! It looks like most of the missing/TODO bits are for optional functionality, so that's cool.  We do want the sample rate and latency stuff for WebAudio/WebRTC, but it will work (suboptimally) without it, so the patch is basically fine to land as a first pass.  I don't know RemoteIO at all, so I can't offer much immediate help, but happy to help out where I can.

::: media/libcubeb/src/cubeb_audiounit.c:447
(Diff revision 1)
> -
> +#if !TARGET_OS_IPHONE

Return CUBEB_ERROR_NOT_SUPPORTED for iOS for now.

::: media/libcubeb/src/cubeb_audiounit.c:462
(Diff revision 1)
> +#if !TARGET_OS_IPHONE

Ditto here.

::: media/libcubeb/src/cubeb_audiounit.c:648
(Diff revision 1)
> +#endif

Move the endif below the buffer_size setting stuff, since latency_range will be uninitialized here.

::: media/libcubeb/src/cubeb_audiounit.c:848
(Diff revision 1)
> +  //TODO

Return CUBEB_ERROR_NOT_SUPPORTED.

::: media/libcubeb/src/cubeb_audiounit.c:887
(Diff revision 1)
> +  return CUBEB_ERROR;

CUBEB_ERROR_NOT_SUPPORTED
https://hg.mozilla.org/mozilla-central/rev/d832a498605f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.