1171125 - Fix nsStackWalk to build for iOS

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(not currently active) Ted Mielczarek]

I don't actually know if it works, but I got it to build.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: MozReview Request: bug 1171125 - Fix nsStackWalk to build for iOS. r?froydnj

bug 1171125 - Fix nsStackWalk to build for iOS. r?froydnj

Comment 2

[(not currently active) Ted Mielczarek]

I just realized there's a TODO left in that patch, but I don't know what for. I think this code only builds for the iOS simulator given the __i386__ || __ppc__ bit (although it's possible I have HAVE__UNWIND_BACKTRACE on iOS).

Comment 3

[(not currently active) Ted Mielczarek]

I don't see it in mozilla-config.h, so I'm guessing this code doesn't build for arm-darwin.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8614850 [details]
MozReview Request: bug 1171125 - Fix nsStackWalk to build for iOS. r?froydnj

https://reviewboard.mozilla.org/r/10083/#review8877

r=me with one small change.

::: xpcom/base/nsStackWalk.cpp:56
(Diff revision 1)
> +//TODO

Since this code apparently doesn't build on iOS, given NSSTACKWALK_SUPPORTS_MACOSX is false, can you make this TODO an #error, so that if somebody naively tries to enable this, they'll know there are other things to fix?

Comment 5

[(not currently active) Ted Mielczarek]

https://reviewboard.mozilla.org/r/10083/#review9107

::: xpcom/base/nsStackWalk.cpp:56
(Diff revision 1)
> +//TODO

Actually I think that include is only for the Gestalt that's used for OSXVersion(), so I'm just going to remove the else/TODO bits.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2ac8aeeac4e

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c2ac8aeeac4e