Closed Bug 1171146 Opened 9 years ago Closed 9 years ago

Display a learn more link in the error doorhanger when refusing to install an unsigned add-on

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla41
Tracking Status
firefox40 + verified
firefox41 + verified

People

(Reporter: mossop, Assigned: dao)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]:

The original mockups included this for users to understand why Firefox was refusing to install an add-on but they were never added.
QA Contact: vasilica.mihasca
Attached patch patchSplinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8615233 - Flags: review?(dtownsend)
Comment on attachment 8615233 [details] [diff] [review]
patch

>+        // Can't have multiple notifications with the same ID, so stop here.
>+        break;

This may seem unrelated to the rest of this patch, but I added it because setting options.learnMoreURL in one loop iteration would affect subsequent iterations, because it's one and the same options object.
Tracking enabled for 40 and 41, so we find a solution and provide users suitable feedback for their actions. Perhaps we have a notification pane with an id, each notification receives a unique id, and they appear in a unordered list.
(In reply to jen strickland :jenstrickland from comment #3)
> Tracking enabled for 40 and 41, so we find a solution and provide users
> suitable feedback for their actions. Perhaps we have a notification pane
> with an id, each notification receives a unique id, and they appear in a
> unordered list.

This is similar to what I want to do for bug 1163973 but it is likely to be too invasive to justify uplift.
Comment on attachment 8615233 [details] [diff] [review]
patch

Review of attachment 8615233 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-addons.js
@@ +171,5 @@
>            args = [brandShortName, Services.appinfo.version, install.name];
>          }
>  
> +        // Add Learn More link when refusing to install an unsigned add-on
> +        if (install.error == -5) {

For clarity use AddonManager.ERROR_SIGNEDSTATE_REQUIRED instead of -5 here.
Attachment #8615233 - Flags: review?(dtownsend) → review+
https://hg.mozilla.org/mozilla-central/rev/99d0f18751fd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment on attachment 8615233 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1139656
[User impact if declined]: Provides a more information to the user when using unsigned add-ons
[Describe test coverage new/current, TreeHerder]: Been in nightly for a while
[Risks and why]: Very low risk
[String/UUID change made/needed]: None
Attachment #8615233 - Flags: approval-mozilla-aurora?
Comment on attachment 8615233 [details] [diff] [review]
patch

More information is good! Taking it.
Attachment #8615233 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Needs rebasing for Aurora uplift.
Flags: needinfo?(dao)
I'm handling this along with another bug
Flags: needinfo?(dao) → needinfo?(dtownsend)
I confirm that “Learn more…” link is displayed in the error doorhanger for unsigned add-ons. 

But I noticed that “Learn more…” link from Nightly opens https://support.mozilla.org/en-US/kb/add-ons-signing-firefox?as=u&utm_source=inproduct and “Learn more…” from Aurora opens https://wiki.mozilla.org/Addons/Extension_Signing .
Shouldn’t be only one page opened in both Firefox versions?

“Learn more…” link shouldn’t be displayed in the error doorhanger also for corrupted add-ons?

Tested on Firefox 41.0a1 (2015-06-10) and Firefox 40.0a2 (2015-06-10) using Ubuntu 12.02 x64, Windows 7 x64 and Mac OS X 10.9.5
Flags: needinfo?(dtownsend)
(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #13)
> I confirm that “Learn more…” link is displayed in the error doorhanger for
> unsigned add-ons. 
> 
> But I noticed that “Learn more…” link from Nightly opens
> https://support.mozilla.org/en-US/kb/add-ons-signing-
> firefox?as=u&utm_source=inproduct and “Learn more…” from Aurora opens
> https://wiki.mozilla.org/Addons/Extension_Signing .
> Shouldn’t be only one page opened in both Firefox versions?

It was changed in bug 1170162, I'll be requesting uplift to aurora soon.

> “Learn more…” link shouldn’t be displayed in the error doorhanger also for
> corrupted add-ons?

We don't know why the add-on is corrupt so it isn't appropriate to direct the user to a page about signing at this point.
Flags: needinfo?(dtownsend)
Based on the above mentions, I am making this bug as Verified Fixed since the other issue is tracked separately.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.