Closed Bug 1171159 Opened 9 years ago Closed 9 years ago

fix talos media_tests to not import talos.utils

Categories

(Testing :: Talos, defect)

defect
Not set
normal

Tracking

(firefox41 affected)

RESOLVED FIXED
Tracking Status
firefox41 --- affected

People

(Reporter: jmaher, Unassigned)

References

Details

Attachments

(1 file)

as we remove the requirement of running talos as a package itself, we run into problems with the media_tests, specifically where we import talos.utils:
http://hg.mozilla.org/build/talos/file/b55193016019/talos/startup_test/media/media_manager.py#l10

Ideally we can fix this easily.  I am not sure what utils we need, maybe removing that need is easy, or hacking sys.path.
See Also: → 1171199
now that bug 1171199 is resolved, lets see what else we can do here.
Now that the step 2 of bug 1171199 is finished, the import taols.utils has been replaced with mozlog:

http://hg.mozilla.org/build/talos/file/81ba38b8ec6a/talos/startup_test/media/media_manager.py#l9

Maybe this bug is fixed with this side effect ?
Flags: needinfo?(jmaher)
yes, this issue is fixed now!  We could have some issues still as we import modules from startup_tests/media.

:jlund, can you push to try with the patch applied, this time ensure -p linux64,win -t all :)  Make sure that you update talos.json to point to the latest sources.
Flags: needinfo?(jmaher) → needinfo?(jlund)
(In reply to Joel Maher (:jmaher) from comment #3)
> yes, this issue is fixed now!  We could have some issues still as we import
> modules from startup_tests/media.
> 
> :jlund, can you push to try with the patch applied, this time ensure -p
> linux64,win -t all :)  Make sure that you update talos.json to point to the
> latest sources.

looks like we are good, specifically talos other. should I re-land?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=beb3a0030562
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d36e23ce3b49
Flags: needinfo?(jlund) → needinfo?(jmaher)
awesome!  lets reland.  fyi- I am on pto tomorrow, so backout if any questions or wait a day :)
Flags: needinfo?(jmaher)
looks like aurora already was updated with trunk so it is just beta afaik. That is on the assumption that we do not run talos on m-r/esr or any b2g branches.
Attachment #8623767 - Flags: review?(jmaher)
Attachment #8623767 - Flags: review?(jmaher) → review+
Comment on attachment 8623767 [details] [diff] [review]
update m-b to match m-c and m-a desktop talos.json pin

thanks!

remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/2f8d779efaa1
:jmaher, shouldn't we close this bug as resolved ?
Flags: needinfo?(jmaher)
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(jmaher)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.