Gaia local npm dependencies should be able to require other local npm packages

RESOLVED FIXED

Status

Testing
JSMarionette
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gaye, Assigned: gaye)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This blocks bug 1165496. See for https://github.com/npm/npm/issues/8422 one suggestion for an upstream change to npm that would fix this.
(Assignee)

Updated

2 years ago
Blocks: 1165496
(Assignee)

Comment 1

2 years ago
Created attachment 8615533 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30427

r=self. For the meantime, we can hack around this by using peerDependencies and explicitly depending on all of our local modules in our top-level package.json.
Attachment #8615533 - Flags: review+
(Assignee)

Updated

2 years ago
Assignee: nobody → gaye
(Assignee)

Comment 2

2 years ago
landed on master https://github.com/mozilla-b2g/gaia/commit/65369b217faac7d70c1a29100c4208c6d1db16e3
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.