117119 - BMP and ICO decoders should use ReadSegments, not Read

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P2)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

ReadSegments is faster because it avoids a memory alloocation and copy.

Will attach a patch soon.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: Patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Pavlov, could you review this patch? TIA

Comment 3

[Stuart Parmenter]

Comment on attachment 62885 [details] [diff] [review]
Patch

r=pavlov

Comment 4

[tor]

Comment on attachment 62885 [details] [diff] [review]
Patch

sr=tor

Comment 5

[Vicente Salvador]

This bug has r= and sr=. Hi Christian, could you request an a=

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Vicente, I don't think that this patch is needed for 0.9.8, nor do I think it
will get a=.

I'll have somebody check it in as soon as the tree opens.

Setting Target Milestone to 0.9.9. (forgot to do that earlier)

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

timeless checked this in, marking fixed