BMP and ICO decoders should use ReadSegments, not Read

RESOLVED FIXED in mozilla0.9.9

Status

()

Core
ImageLib
P2
normal
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

({perf})

Trunk
mozilla0.9.9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

ReadSegments is faster because it avoids a memory alloocation and copy.

Will attach a patch soon.

Updated

16 years ago
Keywords: perf
Pavlov, could you review this patch? TIA
Priority: -- → P2
Target Milestone: --- → mozilla0.9.8

Comment 3

16 years ago
Comment on attachment 62885 [details] [diff] [review]
Patch

r=pavlov
Attachment #62885 - Flags: review+

Comment 4

16 years ago
Comment on attachment 62885 [details] [diff] [review]
Patch

sr=tor
Attachment #62885 - Flags: superreview+

Comment 5

16 years ago
This bug has r= and sr=. Hi Christian, could you request an a=
Vicente, I don't think that this patch is needed for 0.9.8, nor do I think it
will get a=.

I'll have somebody check it in as soon as the tree opens.

Setting Target Milestone to 0.9.9. (forgot to do that earlier)
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9.8 → mozilla0.9.9
timeless checked this in, marking fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.